From 2763f7e1377e9f961ea5f3b65671d9535391f5aa Mon Sep 17 00:00:00 2001 From: evazion Date: Sun, 8 Jan 2017 00:57:36 +0000 Subject: [PATCH] Fix ordering of favlists (sort by users who favorited first). Fix bug introduced in 6e62a4c. --- app/models/post.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/models/post.rb b/app/models/post.rb index 558fab286..57295f4a5 100644 --- a/app/models/post.rb +++ b/app/models/post.rb @@ -960,12 +960,12 @@ class Post < ActiveRecord::Base rescue PostVote::Error end - def favorited_user_ids - fav_string.scan(/\d+/) - end - + # users who favorited this post, ordered by users who favorited it first def favorited_users - User.find(favorited_user_ids).reject(&:hide_favorites?) + favorited_user_ids = fav_string.scan(/\d+/).map(&:to_i) + visible_users = User.find(favorited_user_ids).reject(&:hide_favorites?) + ordered_users = visible_users.index_by(&:id).slice(*favorited_user_ids).values + ordered_users end def favorite_groups(active_id=nil)