From 627e8e10136b69930bd6caf7233ac3afabebd7ea Mon Sep 17 00:00:00 2001 From: evazion Date: Wed, 29 Sep 2021 06:04:28 -0500 Subject: [PATCH] cron: fix undefined variable in exception handler (again) Fixup for a1d4408c2. --- app/logical/danbooru_maintenance.rb | 2 +- test/unit/danbooru_maintenance_test.rb | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/app/logical/danbooru_maintenance.rb b/app/logical/danbooru_maintenance.rb index be3122ade..d77fd9862 100644 --- a/app/logical/danbooru_maintenance.rb +++ b/app/logical/danbooru_maintenance.rb @@ -32,7 +32,7 @@ module DanbooruMaintenance ApplicationRecord.connection.verify! job.perform_later rescue Exception => e # rubocop:disable Lint/RescueException - DanbooruLogger.log(exception) + DanbooruLogger.log(e) raise e if Rails.env.test? end end diff --git a/test/unit/danbooru_maintenance_test.rb b/test/unit/danbooru_maintenance_test.rb index 5d73753ba..b77301ed4 100644 --- a/test/unit/danbooru_maintenance_test.rb +++ b/test/unit/danbooru_maintenance_test.rb @@ -8,6 +8,16 @@ class DanbooruMaintenanceTest < ActiveSupport::TestCase perform_enqueued_jobs end end + + should "log errors" do + assert_raise(RuntimeError) do + PrunePostsJob.stubs(:perform_later).raises(RuntimeError) + DanbooruLogger.expects(:log) + + DanbooruMaintenance.hourly + perform_enqueued_jobs + end + end end context "daily maintenance" do