From 63203d24ccab406c982008c2dd433ffafccbcad4 Mon Sep 17 00:00:00 2001 From: BrokenEagle Date: Mon, 13 Jan 2020 21:12:45 +0000 Subject: [PATCH] Standardize use of column width parameter --- app/views/artist_commentaries/index.html.erb | 2 +- .../artist_commentary_versions/_listing.html.erb | 6 +++--- app/views/note_versions/_listing.html.erb | 10 +++++----- app/views/pools/index.html.erb | 4 ++-- app/views/post_appeals/index.html.erb | 12 ++++++------ app/views/post_approvals/index.html.erb | 4 ++-- app/views/post_flags/index.html.erb | 14 +++++++------- app/views/post_replacements/index.html.erb | 2 +- app/views/tag_aliases/_listing.html.erb | 10 +++++----- app/views/tag_implications/_listing.html.erb | 10 +++++----- app/views/wiki_page_versions/_listing.html.erb | 4 ++-- 11 files changed, 39 insertions(+), 39 deletions(-) diff --git a/app/views/artist_commentaries/index.html.erb b/app/views/artist_commentaries/index.html.erb index c5c3ef765..fbecb4f14 100644 --- a/app/views/artist_commentaries/index.html.erb +++ b/app/views/artist_commentaries/index.html.erb @@ -5,7 +5,7 @@ <%= render "posts/partials/common/inline_blacklist" %> <%= table_for @commentaries, width: "100%" do |t| %> - <% t.column "Post", {width: "1%"} do |commentary| %> + <% t.column "Post", width: "1%" do |commentary| %> <%= PostPresenter.preview(commentary.post, :tags => "status:any") %> <% end %> <% t.column "Original" do |commentary| %> diff --git a/app/views/artist_commentary_versions/_listing.html.erb b/app/views/artist_commentary_versions/_listing.html.erb index 69a33b7ab..2f2e1f18d 100644 --- a/app/views/artist_commentary_versions/_listing.html.erb +++ b/app/views/artist_commentary_versions/_listing.html.erb @@ -1,7 +1,7 @@
<%= table_for @commentary_versions, {class: "striped autofit", width: "100%"} do |t| %> - <% t.column "Post", {width: "5%"} do |commentary_version| %> + <% t.column "Post", width: "5%" do |commentary_version| %> <% if artist_commentary_versions_listing_type == :revert %> <%= link_to commentary_version.post_id, post_path(commentary_version.post_id) %> <% else %> @@ -21,10 +21,10 @@ <%= format_commentary_title(commentary_version.translated_title) %> <%= format_commentary_description(commentary_version.translated_description) %> <% end %> - <% t.column "Edited by", {width: "10%"} do |commentary_version| %> + <% t.column "Edited by", width: "10%" do |commentary_version| %> <%= link_to_user commentary_version.updater %> <% end %> - <% t.column "Date", {width: "10%"} do |commentary_version| %> + <% t.column "Date", width: "10%" do |commentary_version| %> <%= compact_time commentary_version.updated_at %> <% end %> <% if artist_commentary_versions_listing_type == :revert %> diff --git a/app/views/note_versions/_listing.html.erb b/app/views/note_versions/_listing.html.erb index 2838d87d8..74cb8142f 100644 --- a/app/views/note_versions/_listing.html.erb +++ b/app/views/note_versions/_listing.html.erb @@ -2,13 +2,13 @@ <%= table_for @note_versions, {class: "striped autofit", width: "100%"} do |t| %> <% t.column column: "empty" %> - <% t.column "Post", {width: "5%"} do |note_version| %> + <% t.column "Post", width: "5%" do |note_version| %> <%= link_to note_version.post_id, post_path(note_version.post_id) %> <% if params.dig(:search, :note_id).present? %> <%= link_to "»", note_versions_path(search: {post_id: note_version.post_id}) %> <% end %> <% end %> - <% t.column "Note", {width: "5%"} do |note_version| %> + <% t.column "Note", width: "5%" do |note_version| %> <%= link_to "#{note_version.note_id}.#{note_version.version}", post_path(note_version.post_id, anchor: "note-#{note_version.note_id}") %> <% if params.dig(:search, :post_id).present? %> <%= link_to "»", note_versions_path(search: {note_id: note_version.note_id}) %> @@ -21,13 +21,13 @@ <% end %> <%= note_version_body_diff_info(note_version) %> <% end %> - <% t.column "Position", {width: "5%"} do |note_version| %> + <% t.column "Position", width: "5%" do |note_version| %> <%= note_version_position_diff(note_version) %> <% end %> - <% t.column "Edited By", {width: "10%"} do |note_version| %> + <% t.column "Edited By", width: "10%" do |note_version| %> <%= link_to_user note_version.updater %> <% end %> - <% t.column "Date", {width: "10%"} do |note_version| %> + <% t.column "Date", width: "10%" do |note_version| %> <%= compact_time note_version.updated_at %> <% end %> <% if note_versions_listing_type == :revert %> diff --git a/app/views/pools/index.html.erb b/app/views/pools/index.html.erb index 48e8817da..c65b4ebc0 100644 --- a/app/views/pools/index.html.erb +++ b/app/views/pools/index.html.erb @@ -3,7 +3,7 @@ <%= render "search", :path => pools_path %> <%= table_for @pools, width: "100%" do |t| %> - <% t.column "Name", {width: "60%"} do |pool| %> + <% t.column "Name", width: "60%" do |pool| %> <%= link_to pool.pretty_name, pool_path(pool) %> <% if pool.is_deleted? %> (deleted) @@ -12,7 +12,7 @@ <%= link_to "page #{pool.last_page}", pool_path(pool, :page => pool.last_page), :class => "last-page" %> <% end %> <% end %> - <% t.column "Count", {width: "10%"} do |pool| %> + <% t.column "Count", width: "10%" do |pool| %> <%= pool.post_count %> <% end %> <% end %> diff --git a/app/views/post_appeals/index.html.erb b/app/views/post_appeals/index.html.erb index a1e7853bb..ddca78198 100644 --- a/app/views/post_appeals/index.html.erb +++ b/app/views/post_appeals/index.html.erb @@ -5,7 +5,7 @@ <%= render "posts/partials/common/inline_blacklist" %> <%= table_for @post_appeals, width: "100%" do |t| %> - <% t.column "Post", {width: "1%"} do |post_appeal| %> + <% t.column "Post", width: "1%" do |post_appeal| %> <%= PostPresenter.preview(post_appeal.post, :tags => "status:any") %> <% end %> <% t.column "Reason" do |post_appeal| %> @@ -13,23 +13,23 @@ <%= format_text post_appeal.reason, inline: true %> <% end %> - <% t.column "Appeals", {width: "1%"} do |post_appeal| %> + <% t.column "Appeals", width: "1%" do |post_appeal| %> <%= link_to post_appeal.post.appeals.size, post_appeals_path(search: { post_id: post_appeal.post_id }) %> <% end %> - <% t.column "Resolved?", {width: "5%"} do |post_appeal| %> + <% t.column "Resolved?", width: "5%" do |post_appeal| %> <%= link_to post_appeal.is_resolved.to_s, post_appeals_path(search: params[:search].merge(is_resolved: post_appeal.is_resolved)) %> <% end %> - <% t.column "Uploaded", {width: "15%"} do |post_appeal| %> + <% t.column "Uploaded", width: "15%" do |post_appeal| %> <%= compact_time post_appeal.post.created_at %>
by <%= link_to_user post_appeal.post.uploader %> <%= link_to "»", post_appeals_path(search: params[:search].merge(post_tags_match: "#{params[:search][:post_tags_match]} user:#{post_appeal.post.uploader.name}".strip)) %> <% end %> - <% t.column "Appealed", {width: "15%"} do |post_appeal| %> + <% t.column "Appealed", width: "15%" do |post_appeal| %> <%= compact_time post_appeal.created_at %>
by <%= link_to_user post_appeal.creator %> <%= link_to "»", post_appeals_path(search: params[:search].merge(creator_name: post_appeal.creator.name)) %> <% end %> - <% t.column "Approver", {width: "15%"} do |post_appeal| %> + <% t.column "Approver", width: "15%" do |post_appeal| %> <% if post_appeal.post.approver %> <%= link_to_user post_appeal.post.approver %> <%= link_to "»", post_appeals_path(search: params[:search].merge(post_tags_match: "#{params[:search][:post_tags_match]} approver:#{post_appeal.post.approver.name}".strip)) %> diff --git a/app/views/post_approvals/index.html.erb b/app/views/post_approvals/index.html.erb index 8955aeff5..e10debb94 100644 --- a/app/views/post_approvals/index.html.erb +++ b/app/views/post_approvals/index.html.erb @@ -10,10 +10,10 @@ <% end %> <%= table_for @post_approvals, width: "100%" do |t| %> - <% t.column "Post", {width: "1%"} do |post_approval| %> + <% t.column "Post", width: "1%" do |post_approval| %> <%= PostPresenter.preview(post_approval.post, :tags => "status:any") %> <% end %> - <% t.column "Approver", {width: "15%"} do |post_approval| %> + <% t.column "Approver", width: "15%" do |post_approval| %> <%= link_to_user post_approval.user %> <%= link_to "»", post_approvals_path(search: params[:search].merge(user_name: post_approval.user.name)) %>
<%= time_ago_in_words_tagged post_approval.created_at %> diff --git a/app/views/post_flags/index.html.erb b/app/views/post_flags/index.html.erb index c20847856..9bb112309 100644 --- a/app/views/post_flags/index.html.erb +++ b/app/views/post_flags/index.html.erb @@ -5,7 +5,7 @@ <%= render "posts/partials/common/inline_blacklist" %> <%= table_for @post_flags, width: "100%" do |t| %> - <% t.column "Post", {width: "1%"} do |post_flag| %> + <% t.column "Post", width: "1%" do |post_flag| %> <%= PostPresenter.preview(post_flag.post, :tags => "status:any") %> <% end %> <% t.column "Reason" do |post_flag| %> @@ -13,28 +13,28 @@ <%= format_text post_flag.reason, inline: true %> <% end %> - <% t.column "Flags", {width: "1%"} do |post_flag| %> + <% t.column "Flags", width: "1%" do |post_flag| %> <%= link_to post_flag.post.flags.size, post_flags_path(search: { post_id: post_flag.post_id }) %> <% end %> - <% t.column "Category", {width: "1%"} do |post_flag| %> + <% t.column "Category", width: "1%" do |post_flag| %> <%= link_to post_flag.category.to_s, post_flags_path(search: params[:search].merge(category: post_flag.category)) %> <% end %> - <% t.column "Resolved?", {width: "1%"} do |post_flag| %> + <% t.column "Resolved?", width: "1%" do |post_flag| %> <%= link_to post_flag.is_resolved?.to_s, post_flags_path(search: params[:search].merge(is_resolved: post_flag.is_resolved?)) %> <% end %> - <% t.column "Uploaded", {width: "15%"} do |post_flag| %> + <% t.column "Uploaded", width: "15%" do |post_flag| %> <%= compact_time post_flag.post.created_at %>
by <%= link_to_user post_flag.post.uploader %> <%= link_to "»", post_flags_path(search: params[:search].merge(post_tags_match: "#{params[:search][:post_tags_match]} user:#{post_flag.post.uploader.name}".strip)) %> <% end %> - <% t.column "Flagged", {width: "15%"} do |post_flag| %> + <% t.column "Flagged", width: "15%" do |post_flag| %> <%= compact_time post_flag.created_at %> <% if CurrentUser.can_view_flagger_on_post?(post_flag) %>
by <%= link_to_user post_flag.creator %> <%= link_to "»", post_flags_path(search: params[:search].merge(creator_name: post_flag.creator.name)) %> <% end %> <% end %> - <% t.column "Approver", {width: "15%"} do |post_flag| %> + <% t.column "Approver", width: "15%" do |post_flag| %> <% if post_flag.post.approver %> <%= link_to_user post_flag.post.approver %> <%= link_to "»", post_flags_path(search: params[:search].merge(post_tags_match: "#{params[:search][:post_tags_match]} approver:#{post_flag.post.approver.name}".strip)) %> diff --git a/app/views/post_replacements/index.html.erb b/app/views/post_replacements/index.html.erb index f1be1e259..e367cfdc8 100644 --- a/app/views/post_replacements/index.html.erb +++ b/app/views/post_replacements/index.html.erb @@ -11,7 +11,7 @@ <% end %> <%= table_for @post_replacements, {class: "striped autofit", width: "100%"} do |t| %> - <% t.column "Post", {width: "1%"} do |post_replacement| %> + <% t.column "Post", width: "1%" do |post_replacement| %> <%= PostPresenter.preview(post_replacement.post, show_deleted: true) %> <% end %> <% t.column "Source" do |post_replacement| %> diff --git a/app/views/tag_aliases/_listing.html.erb b/app/views/tag_aliases/_listing.html.erb index 730acb3b0..bcef4a136 100644 --- a/app/views/tag_aliases/_listing.html.erb +++ b/app/views/tag_aliases/_listing.html.erb @@ -1,19 +1,19 @@ <%= table_for tag_aliases, width: "100%" do |t| %> - <% t.column "From", {width: "25%"} do |tag_alias| %> + <% t.column "From", width: "25%" do |tag_alias| %> <%= link_to tag_alias.antecedent_name, posts_path(:tags => tag_alias.antecedent_name) %> <%= tag_alias.antecedent_tag.post_count rescue 0 %> <% end %> - <% t.column "To", {width: "25%"} do |tag_alias| %> + <% t.column "To", width: "25%" do |tag_alias| %> <%= link_to tag_alias.consequent_name, posts_path(:tags => tag_alias.consequent_name) %> <%= tag_alias.consequent_tag.post_count rescue 0 %> <% end %> - <% t.column "Reference", {width: "10%"} do |tag_alias| %> + <% t.column "Reference", width: "10%" do |tag_alias| %> <% if tag_alias.forum_topic_id %> <%= link_to tag_alias.forum_topic_id, forum_topic_path(tag_alias.forum_topic_id) %> <% end %> <% end %> - <% t.column "Approver", {width: "15%"} do |tag_alias| %> + <% t.column "Approver", width: "15%" do |tag_alias| %> <%= link_to_user(tag_alias.approver) if tag_alias.approver %> <% end %> - <% t.column "Status", {width: "5%"} do |tag_alias| %> + <% t.column "Status", width: "5%" do |tag_alias| %> <%= tag_alias.status %> <% end %> <% t.column column: "control", width: "15%" do |tag_alias| %> diff --git a/app/views/tag_implications/_listing.html.erb b/app/views/tag_implications/_listing.html.erb index 94543a8c8..441bedae7 100644 --- a/app/views/tag_implications/_listing.html.erb +++ b/app/views/tag_implications/_listing.html.erb @@ -1,19 +1,19 @@ <%= table_for tag_implications, width: "100%" do |t| %> - <% t.column "From", {width: "25%"} do |tag_implication| %> + <% t.column "From", width: "25%" do |tag_implication| %> <%= link_to tag_implication.antecedent_name, posts_path(:tags => tag_implication.antecedent_name) %> <%= tag_implication.antecedent_tag.post_count rescue 0 %> <% end %> - <% t.column "To", {width: "25%"} do |tag_implication| %> + <% t.column "To", width: "25%" do |tag_implication| %> <%= link_to tag_implication.consequent_name, posts_path(:tags => tag_implication.consequent_name) %> <%= tag_implication.consequent_tag.post_count rescue 0 %> <% end %> - <% t.column "Reference", {width: "10%"} do |tag_implication| %> + <% t.column "Reference", width: "10%" do |tag_implication| %> <% if tag_implication.forum_topic_id %> <%= link_to tag_implication.forum_topic_id, forum_topic_path(tag_implication.forum_topic_id) %> <% end %> <% end %> - <% t.column "Approver", {width: "15%"} do |tag_implication| %> + <% t.column "Approver", width: "15%" do |tag_implication| %> <%= link_to_user(tag_implication.approver) if tag_implication.approver %> <% end %> - <% t.column "Status", {width: "5%"} do |tag_implication| %> + <% t.column "Status", width: "5%" do |tag_implication| %> <%= tag_implication.status %> <% end %> <% t.column column: "control", width: "15%" do |tag_implication| %> diff --git a/app/views/wiki_page_versions/_listing.html.erb b/app/views/wiki_page_versions/_listing.html.erb index 32a9d5951..d07336db9 100644 --- a/app/views/wiki_page_versions/_listing.html.erb +++ b/app/views/wiki_page_versions/_listing.html.erb @@ -21,10 +21,10 @@ <%= link_to "»", wiki_page_versions_path(search: { wiki_page_id: wiki_page_version.wiki_page_id }) %> <% end %> - <% t.column "Status", {width: "5%"} do |wiki_page_version| %> + <% t.column "Status", width: "5%" do |wiki_page_version| %> <%= wiki_page_version_status_diff(wiki_page_version) %> <% end %> - <% t.column "Last edited", {width: "26%"} do |wiki_page_version| %> + <% t.column "Last edited", width: "26%" do |wiki_page_version| %> <%= compact_time(wiki_page_version.updated_at) %> by <%= link_to_user wiki_page_version.updater %>