From 637e961f0a72b4fab5bbfcdbd7c3f4798e64ca7c Mon Sep 17 00:00:00 2001
From: evazion <noizave@gmail.com>
Date: Wed, 11 Sep 2019 03:13:10 -0500
Subject: [PATCH] Fix #4167: Add more IDs to side menu elements.

---
 .../posts/partials/show/_information.html.erb | 20 +++---
 .../posts/partials/show/_options.html.erb     | 68 +++++++++++--------
 app/views/posts/show.html.erb                 | 12 ++--
 3 files changed, 56 insertions(+), 44 deletions(-)

diff --git a/app/views/posts/partials/show/_information.html.erb b/app/views/posts/partials/show/_information.html.erb
index 53a30bfda..c0dfc3dc8 100644
--- a/app/views/posts/partials/show/_information.html.erb
+++ b/app/views/posts/partials/show/_information.html.erb
@@ -1,24 +1,24 @@
 <ul>
-  <li>ID: <%= post.id %></li>
+  <li id="post-info-id">ID: <%= post.id %></li>
   <% if CurrentUser.is_moderator? %>
-    <li>Uploader: <%= link_to_user(post.uploader) %></li>
+    <li id="post-info-uploader">Uploader: <%= link_to_user(post.uploader) %></li>
   <% end %>
-  <li>
+  <li id="post-info-date">
     Date: <%= link_to time_ago_in_words_tagged(post.created_at), posts_path(:tags => "date:#{post.created_at.to_date}"), :rel => "nofollow" %>
     <meta itemprop="uploadDate" content="<%= post.created_at.iso8601 %>">
   </li>
   <% if post.approver %>
-    <li>Approver: <%= link_to_user(post.approver) %></li>
+    <li id="post-info-approver">Approver: <%= link_to_user(post.approver) %></li>
   <% end %>
-  <li>
+  <li id="post-info-size">
     Size: <%= link_to_if post.visible?, number_to_human_size(post.file_size), post.tagged_file_url %>
     <% if post.has_dimensions? %>
       (<span itemprop="width"><%= post.image_width %></span>x<span itemprop="height"><%= post.image_height %></span>)
     <% end %>
   </li>
-  <li>Source: <%= post_source_tag(post) %></li>
-  <li>Rating: <%= post.pretty_rating %></li>
-  <li>Score: <span id="score-for-post-<%= post.id %>"><%= post.score %></span>
+  <li id="post-info-source">Source: <%= post_source_tag(post) %></li>
+  <li id="post-info-rating">Rating: <%= post.pretty_rating %></li>
+  <li id="post-info-score">Score: <span id="score-for-post-<%= post.id %>"><%= post.score %></span>
     <% if CurrentUser.is_voter? %>
       <%= tag.span id: "vote-links-for-post-#{post.id}", style: ("display: none;" if !@post.can_be_voted_by?(CurrentUser.user)) do %>
         (vote
@@ -30,13 +30,13 @@
       <% end %>
     <% end %>
   </li>
-  <li>Favorites: <span id="favcount-for-post-<%= post.id %>"><%= post.fav_count %></span>
+  <li id="post-info-favorites">Favorites: <span id="favcount-for-post-<%= post.id %>"><%= post.fav_count %></span>
   <% if CurrentUser.is_gold? %>
     <%= link_to "Show »", "#", id: "show-favlist-link", style: ("display: none;" if post.fav_count == 0) %>
     <%= link_to "« Hide", "#", id: "hide-favlist-link", style: "display: none;" %>
     <div id="favlist" style="display: none;"><%= post_favlist(post) %></div>
   <% end %></li>
-  <li>
+  <li id="post-info-status">
     Status:
     <% if post.is_pending? %>
       Pending
diff --git a/app/views/posts/partials/show/_options.html.erb b/app/views/posts/partials/show/_options.html.erb
index c03171af3..00a87637f 100644
--- a/app/views/posts/partials/show/_options.html.erb
+++ b/app/views/posts/partials/show/_options.html.erb
@@ -1,63 +1,75 @@
 <ul>
-  <li><%= link_to "Resize to window", "#", :id => "image-resize-to-window-link" %></li>
-  <li><%= link_to "Find similar", iqdb_queries_path(:post_id => post.id) %></li>
-  <li><%= link_to_if post.visible?, "Download", post.tagged_file_url + "?download=1", download: post.presenter.filename_for_download %></li>
+  <li id="post-option-resize-to-window">
+    <%= link_to "Resize to window", "#", id: "image-resize-to-window-link" %>
+  </li>
+  <li id="post-option-find-similar">
+    <%= link_to "Find similar", iqdb_queries_path(post_id: post.id) %>
+  </li>
+  <li id="post-option-download">
+    <%= link_to_if post.visible?, "Download", post.tagged_file_url + "?download=1", download: post.presenter.filename_for_download %>
+  </li>
 
   <% if CurrentUser.is_member? %>
-    <li><%= link_to "Favorite", favorites_path(:post_id => post.id), :remote => true, :method => :post, :id => "add-to-favorites", :"data-shortcut" => "f", style: ("display: none;" if @post.is_favorited?) %></li>
-    <li><%= link_to "Unfavorite", favorite_path(post), :remote => true, :method => :delete, :id => "remove-from-favorites", :"data-shortcut" => "shift+f", style: ("display: none;" if !@post.is_favorited?) %></li>
-    <li><%= link_to "Edit", "#edit", :id => "side-edit-link" %></li>
-    <li id="add-to-pool-list"><%= link_to "Add to pool", "#", :id => "pool" %></li>
-    <% if post.is_note_locked? %>
-      <li id="add-notes-list"><span id="note-locked-notice">Note locked</span></li>
-    <% else %>
-      <li id="add-notes-list"><%= link_to "Add note", "#", :id => "translate", :"data-shortcut" => "n" %></li>
-    <% end %>
+    <li id="post-option-add-to-favorites">
+      <%= link_to "Favorite", favorites_path(post_id: post.id), remote: true, method: :post, id: "add-to-favorites", "data-shortcut": "f", style: ("display: none;" if @post.is_favorited?) %>
+    </li>
+    <li id="post-option-remove-from-favorites">
+      <%= link_to "Unfavorite", favorite_path(post), remote: true, method: :delete, id: "remove-from-favorites", "data-shortcut": "shift+f", style: ("display: none;" if !@post.is_favorited?) %>
+    </li>
+    <li id="post-option-edit"><%= link_to "Edit", "#edit", id: "side-edit-link" %></li>
+    <li id="post-option-add-to-pool"><%= link_to "Add to pool", "#", id: "pool" %></li>
+    <li id="post-option-add-note">
+      <% if post.is_note_locked? %>
+        <span id="note-locked-notice">Note locked</span>
+      <% else %>
+        <%= link_to "Add note", "#", id: "translate", "data-shortcut": "n" %>
+      <% end %>
+    </li>
     <% if post.has_notes? %>
-      <li id="copy-all-notes-list"><%= link_to "Copy notes", "#", :id => "copy-notes" %></li>
+      <li id="post-option-copy-notes"><%= link_to "Copy notes", "#", id: "copy-notes" %></li>
     <% end %>
-    <li id="add-artist-commentary-list"><%= link_to "Add commentary", "#", :id => "add-commentary" %></li>
-    <li><%= link_to "Add to fav group", "#", :id => "open-favgroup-dialog-link", :"data-shortcut" => "g" %></li>
+    <li id="post-option-add-commentary"><%= link_to "Add commentary", "#", id: "add-commentary" %></li>
+    <li id="post-option-add-fav-group"><%= link_to "Add to fav group", "#", id: "open-favgroup-dialog-link", "data-shortcut": "g" %></li>
 
     <% if post.is_status_locked? %>
-      <li><span id="status-locked-notice">Status locked</span></li>
+      <li id="post-option-status-locked">Status locked</li>
     <% else %>
       <% unless CurrentUser.no_flagging? %>
         <% if !post.is_deleted? && !post.is_pending? && !post.is_flagged? %>
-          <li><%= link_to "Flag", new_post_flag_path(post_flag: { post_id: post.id }), id: "flag", remote: true %></li>
+          <li id="post-option-flag"><%= link_to "Flag", new_post_flag_path(post_flag: { post_id: post.id }), remote: true %></li>
         <% elsif post.is_flagged? || post.is_deleted? %>
-          <li><%= link_to "Appeal", new_post_appeal_path(post_appeal: { post_id: post.id }), id: "appeal", remote: true %></li>
+          <li id="post-option-appeal"><%= link_to "Appeal", new_post_appeal_path(post_appeal: { post_id: post.id }), remote: true %></li>
         <% end %>
       <% end %>
 
       <% if CurrentUser.can_approve_posts? %>
         <% if post.is_deleted? %>
-          <li><%= link_to "Undelete", undelete_moderator_post_post_path(:post_id => post.id), :remote => true, :method => :post, :id => "undelete", :data => { :confirm => "Are you sure you want to undelete this post?" } %></li>
+          <li id="post-option-undelete"><%= link_to "Undelete", undelete_moderator_post_post_path(post_id: post.id), remote: true, method: :post, "data-confirm": "Are you sure you want to undelete this post?" %></li>
           <% if post.fav_count > 0 && post.parent_id %>
-            <li><%= link_to "Move favorites", confirm_move_favorites_moderator_post_post_path(:post_id => post.id) %></li>
+            <li id="post-option-move-favorites"><%= link_to "Move favorites", confirm_move_favorites_moderator_post_post_path(post_id: post.id) %></li>
           <% end %>
         <% else %>
-          <li><%= link_to "Delete", confirm_delete_moderator_post_post_path(:post_id => post.id) %></li>
+          <li id="post-option-delete"><%= link_to "Delete", confirm_delete_moderator_post_post_path(post_id: post.id) %></li>
         <% end %>
 
         <% if post.is_approvable? && !post.is_deleted? %>
-          <li><%= link_to "Approve", moderator_post_approval_path(:post_id => post.id), :remote => true, :method => :post, :id => "approve", :"data-shortcut" => "shift+o", :"data-confirm" => "Are you sure you want to approve this post?" %></li>
-          <li><%= link_to "Hide from queue", moderator_post_disapprovals_path(post_disapproval: { post_id: post.id, reason: "disinterest" }), remote: true, method: :post, id: "disapprove" %></li>
+          <li id="post-option-approve"><%= link_to "Approve", moderator_post_approval_path(post_id: post.id), remote: true, method: :post, id: "approve", "data-shortcut": "shift+o", "data-confirm": "Are you sure you want to approve this post?" %></li>
+          <li id="post-option-disapprove"><%= link_to "Hide from queue", moderator_post_disapprovals_path(post_disapproval: { post_id: post.id, reason: "disinterest" }), remote: true, method: :post, id: "disapprove" %></li>
         <% end %>
 
         <% if post.is_banned? %>
-          <li><%= link_to "Unban", unban_moderator_post_post_path(post), method: :post, "data-confirm": "Are you sure you want to unban this post?" %></li>
+          <li id="post-option-unban"><%= link_to "Unban", unban_moderator_post_post_path(post), method: :post, "data-confirm": "Are you sure you want to unban this post?" %></li>
         <% else %>
-          <li><%= link_to "Ban", confirm_ban_moderator_post_post_path(post) %></li>
+          <li id="post-option-ban"><%= link_to "Ban", confirm_ban_moderator_post_post_path(post) %></li>
         <% end %>
 
         <% if CurrentUser.is_admin? %>
-          <li><%= link_to "Expunge", expunge_moderator_post_post_path(:post_id => post.id), :remote => true, :method => :post, :id => "expunge", :data => {:confirm => "This will permanently delete this post (meaning the file will be deleted). Are you sure you want to delete this post?"} %></li>
+          <li id="post-option-expunge"><%= link_to "Expunge", expunge_moderator_post_post_path(post_id: post.id), remote: true, method: :post, "data-confirm": "This will permanently delete this post (meaning the file will be deleted). Are you sure you want to delete this post?" %></li>
         <% end %>
 
         <% if CurrentUser.is_moderator? %>
-          <li><%= link_to "Replace image", new_post_replacement_path(post_id: post.id), id: "replace-image", remote: true %></li>
-          <li><%= link_to "Down vote report", reports_down_voting_post_path(post_id: post.id) %></li>
+          <li id="post-option-replace-image"><%= link_to "Replace image", new_post_replacement_path(post_id: post.id), remote: true %></li>
+          <li id="post-option-down-vote-report"><%= link_to "Down vote report", reports_down_voting_post_path(post_id: post.id) %></li>
         <% end %>
       <% end %>
     <% end %>
diff --git a/app/views/posts/show.html.erb b/app/views/posts/show.html.erb
index 53fc69370..423021def 100644
--- a/app/views/posts/show.html.erb
+++ b/app/views/posts/show.html.erb
@@ -27,12 +27,12 @@
       <section id="post-history">
         <h1>History</h1>
         <ul>
-          <li><%= link_to "Tags", post_versions_path(search: { post_id: @post.id }) %></li>
-          <li><%= link_to "Pools", pool_versions_path(search: { post_id: @post.id }) %></li>
-          <li><%= link_to "Notes", note_versions_path(search: { post_id: @post.id }) %></li>
-          <li><%= link_to "Moderation", post_events_path(@post.id) %></li>
-          <li><%= link_to "Commentary", artist_commentary_versions_path(search: { post_id: @post.id }) %></li>
-          <li><%= link_to "Replacements", post_replacements_path(search: {post_id: @post.id }) %></li>
+          <li id="post-history-tags"><%= link_to "Tags", post_versions_path(search: { post_id: @post.id }) %></li>
+          <li id="post-history-pools"><%= link_to "Pools", pool_versions_path(search: { post_id: @post.id }) %></li>
+          <li id="post-history-notes"><%= link_to "Notes", note_versions_path(search: { post_id: @post.id }) %></li>
+          <li id="post-history-moderation"><%= link_to "Moderation", post_events_path(@post.id) %></li>
+          <li id="post-history-commentary"><%= link_to "Commentary", artist_commentary_versions_path(search: { post_id: @post.id }) %></li>
+          <li id="post-history-replacements"><%= link_to "Replacements", post_replacements_path(search: {post_id: @post.id }) %></li>
         </ul>
       </section>
     </aside>