Add ability to use nested only parameter
- The only string works much the same as before with its comma separation -- Nested includes are indicated with square brackets "[ ]" -- The nested include is the value immediately preceding the square brackets -- The only string is the comma separated string inside those brackets - Default includes are split between format types when necessary -- This prevents unnecessary includes from being added on page load - Available includes are those items which are allowed to be accessible to the user -- Some aren't because they are sensitive, such as the creator of a flag -- Some aren't because the number of associated items is too large - The amount of times the same model can be included to prevent recursions -- One exception is the root model may include the same model once --- e.g. the user model can include the inviter which is also the user model -- Another exception is if the include is a has_many association --- e.g. artist urls can include the artist, and then artist urls again
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
class CommentsController < ApplicationController
|
||||
respond_to :html, :xml, :json
|
||||
respond_to :html, :xml, :json, :atom
|
||||
respond_to :js, only: [:new, :destroy, :undelete]
|
||||
before_action :member_only, :except => [:index, :search, :show]
|
||||
skip_before_action :api_check
|
||||
@@ -74,6 +74,18 @@ class CommentsController < ApplicationController
|
||||
|
||||
private
|
||||
|
||||
def default_includes(params)
|
||||
if ["json", "xml"].include?(params[:format])
|
||||
[:creator, :updater]
|
||||
elsif params[:format] == "atom"
|
||||
[:creator, :post]
|
||||
else
|
||||
includes_array = [:creator, :updater, {post: [:uploader]}]
|
||||
includes_array << :votes if CurrentUser.is_member?
|
||||
includes_array
|
||||
end
|
||||
end
|
||||
|
||||
def index_for_post
|
||||
@post = Post.find(params[:post_id])
|
||||
@comments = @post.comments
|
||||
@@ -90,12 +102,8 @@ class CommentsController < ApplicationController
|
||||
end
|
||||
|
||||
def index_by_comment
|
||||
@comments = Comment.includes(:creator, :updater).paginated_search(params)
|
||||
respond_with(@comments) do |format|
|
||||
format.atom do
|
||||
@comments = @comments.includes(:post, :creator).load
|
||||
end
|
||||
end
|
||||
@comments = Comment.paginated_search(params).includes(model_includes(params))
|
||||
respond_with(@comments)
|
||||
end
|
||||
|
||||
def check_privilege(comment)
|
||||
|
||||
Reference in New Issue
Block a user