From 698d732667f1c543249e6507cf91e09d8ad08f44 Mon Sep 17 00:00:00 2001 From: evazion Date: Tue, 11 Jan 2022 12:27:56 -0600 Subject: [PATCH] Fix #4878: Disapproval messages appear out of order. Display disapproval messages in oldest-to-newest order. --- app/views/modqueue/_post.html.erb | 2 +- app/views/posts/partials/show/_notices.html.erb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/views/modqueue/_post.html.erb b/app/views/modqueue/_post.html.erb index e1fdcc8f4..97eeacb13 100644 --- a/app/views/modqueue/_post.html.erb +++ b/app/views/modqueue/_post.html.erb @@ -6,7 +6,7 @@
<%= render "modqueue/quick_mod", post: post %> - <%= render "post_disapprovals/compact_counts", disapprovals: post.disapprovals, post: post %> + <%= render "post_disapprovals/compact_counts", disapprovals: post.disapprovals.order(id: :asc), post: post %>
diff --git a/app/views/posts/partials/show/_notices.html.erb b/app/views/posts/partials/show/_notices.html.erb index 77ded1850..f47540bed 100644 --- a/app/views/posts/partials/show/_notices.html.erb +++ b/app/views/posts/partials/show/_notices.html.erb @@ -16,7 +16,7 @@ <%= render "post_appeals/reasons", appeal: post.appeals.select(&:pending?).last %> <% end %> - <%= render "post_disapprovals/counts", :disapprovals => post.disapprovals, :post => post %> + <%= render "post_disapprovals/counts", disapprovals: post.disapprovals.order(id: :asc), post: post %> <% if policy(PostDisapproval).create? && !post.disapproved_by?(CurrentUser.user) %> <%= render "modqueue/quick_mod", post: post %> @@ -32,7 +32,7 @@

This post was deleted

<% end %> - <%= render "post_disapprovals/counts", :disapprovals => post.disapprovals, :post => post %> + <%= render "post_disapprovals/counts", disapprovals: post.disapprovals.order(id: :asc), post: post %> <% if CurrentUser.id == post.uploader_id %>

If you don't understand why your upload was deleted, you can ask for