From 6a3a04f6ec22396a92de59d6d7ce2fe19a9adb21 Mon Sep 17 00:00:00 2001 From: evazion Date: Tue, 4 Feb 2020 03:33:36 -0600 Subject: [PATCH] dmails: fix unread dmail notice when unread_dmail_count is inconsistent. Fix an exception when the user's unread_dmail_count is nonzero but they don't have any unread dmails. This normally shouldn't happen unless the unread_dmail_count is inconsistent. --- app/helpers/users_helper.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/helpers/users_helper.rb b/app/helpers/users_helper.rb index 8b17b7efc..260120d5d 100644 --- a/app/helpers/users_helper.rb +++ b/app/helpers/users_helper.rb @@ -4,7 +4,7 @@ module UsersHelper end def has_unread_dmails?(user) - user.unread_dmail_count > 0 && (cookies[:hide_dmail_notice].to_i < latest_unread_dmail(user).id) + user.unread_dmail_count > 0 && latest_unread_dmail(user).present? && (cookies[:hide_dmail_notice].to_i < latest_unread_dmail(user).id) end def latest_unread_dmail(user)