Fix #3984: Twitter: undefined method `first' for nil:NilClass.

Fix Sources::Strategies::Twitter#image_urls to return an empty array instead of nil when the tweet doesn't contain any images.
2018-11-11 17:41:32 -06:00
parent a20eba9ef7
commit 6a7cd6ce8e
4 changed files with 17 additions and 10 deletions
--- a/app/views/uploads/_image.html.erb
+++ b/app/views/uploads/_image.html.erb
@@ -1,7 +1,7 @@
 <% if params[:url] %>
  <% if ImageProxy.needs_proxy?(@source.image_url) %>
    <%= image_tag(image_proxy_uploads_path(:url => @source.image_url), :title => "Preview", :id => "image") %>
-  <% else %>
+  <% elsif @source.image_url.present? %>
    <%= image_tag(@source.image_url, :title => "Preview", :id => "image") %>
  <% end %>