jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

uploads: fix error when source doesn't have any images.

Browse Source 
Fix an error when trying to upload a source that doesn't have any
images, for example a Twitter post with no images.
This commit is contained in:
evazion
2022-02-15 18:22:26 -06:00
parent e4d7453180
commit 6b56b6a122
2 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
test/functional/uploads_controller_test.rb
View File

@@ -258,6 +258,16 @@ class UploadsControllerTest < ActionDispatch::IntegrationTest
end
end
context "for a source that doesn't contain any images" do
should "fail" do
create_upload!("https://twitter.com/danboorubot/status/923612084616577024", user: @user)
assert_response 201
assert_equal(true, Upload.last.is_errored?)
assert_match("doesn't contain any images", Upload.last.error)
end
end
should "work for a source URL containing unicode characters" do
source1 = "https://cdn.donmai.us/original/d3/4e/d34e4cf0a437a5d65f8e82b7bcd02606.jpg?one=東方&two=a%20b"
source2 = "https://cdn.donmai.us/original/d3/4e/d34e4cf0a437a5d65f8e82b7bcd02606.jpg?one=%E6%9D%B1%E6%96%B9&two=a%20b"