Fix #4017: Artist tag in upload page should account for aliases

Disallow creating artist entries for aliased tags. Add a fix script to
move existing artist entries for tags that have been aliased.
This commit is contained in:
evazion
2022-02-01 12:17:52 -06:00
parent 2d47ae70b0
commit 6d2a2eee59
3 changed files with 47 additions and 6 deletions

View File

@@ -517,6 +517,14 @@ class ArtistTest < ActiveSupport::TestCase
assert(artist.invalid?)
assert_match(/'touhou' is a copyright tag/, artist.errors.full_messages.join)
end
should "not allow creating artist entries for aliased tags" do
tag_alias = create(:tag_alias, antecedent_name: "foo", consequent_name: "bar")
artist = build(:artist, name: "foo")
assert_equal(true, artist.invalid?)
assert_match(/'foo' is aliased to 'bar'/, artist.errors.full_messages.join)
end
end
context "when renaming" do