Set approver of aliases/implications in BURs.
Previously only the BUR's approver was set when a BUR was approved. Set the approver for each alias/implication in the BUR as well. Additionally: * Refactor `approve!` to take a user instead of just a user id. * Be mass-assignment permissions aware when setting approver_id.
This commit is contained in:
@@ -33,12 +33,10 @@ class BulkUpdateRequest < ActiveRecord::Base
|
||||
|
||||
extend SearchMethods
|
||||
|
||||
def approve!(approver_id)
|
||||
self.approver_id = approver_id
|
||||
AliasAndImplicationImporter.new(script, forum_topic_id, "1", true).process!
|
||||
self.status = "approved"
|
||||
self.skip_secondary_validations = true
|
||||
save
|
||||
def approve!(approver)
|
||||
AliasAndImplicationImporter.new(script, forum_topic_id, "1", true).process!(approver)
|
||||
|
||||
update({ :status => "approved", :approver_id => approver.id, :skip_secondary_validations => true }, :as => approver.role)
|
||||
update_forum_topic_for_approve
|
||||
|
||||
rescue Exception => x
|
||||
|
||||
Reference in New Issue
Block a user