From 6e62a4cc33e82f1dca56ffb52d634b0d2eef61f5 Mon Sep 17 00:00:00 2001 From: evazion Date: Tue, 3 Jan 2017 18:14:56 +0000 Subject: [PATCH] Optimize Post#favorited_users. Load users in one query rather than one query per user. --- app/models/post.rb | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/models/post.rb b/app/models/post.rb index e138fc230..4902d9e07 100644 --- a/app/models/post.rb +++ b/app/models/post.rb @@ -965,9 +965,7 @@ class Post < ActiveRecord::Base end def favorited_users - favorited_user_ids.map {|id| User.find(id)}.select do |x| - !x.hide_favorites? - end + User.find(favorited_user_ids).reject(&:hide_favorites?) end def favorite_groups(active_id=nil)