jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

uploads: disallow more video formats not supported by all browsers.

Browse Source 
Disallow uploading videos with 10-bit color or 4:4:4 chroma subsampling.
Neither of these features are supported by Firefox.

Only 8 such videos have been uploaded to Danbooru:

* https://danbooru.donmai.us/media_assets/3070695 (4:4:4)
* https://danbooru.donmai.us/media_assets/3070697 (4:4:4)
* https://danbooru.donmai.us/media_assets/3292518 (4:4:4)
* https://danbooru.donmai.us/media_assets/3358659 (10-bit)
* https://danbooru.donmai.us/media_assets/3358660 (10-bit)
* https://danbooru.donmai.us/media_assets/3730866 (10-bit)
* https://danbooru.donmai.us/media_assets/5056665 (10-bit)
* https://danbooru.donmai.us/media_assets/5479605 (4:4:4)

Note that Exiftool doesn't output this information, so it's not in the
EXIF metadata. We have to reply on ffprobe at upload time instead.

Followup to #3615.
This commit is contained in:
evazion
2022-10-28 01:21:34 -05:00
parent 57316dc622
commit 6e685cdd42
15 changed files with 81 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
test/functional/uploads_controller_test.rb
View File

@@ -243,12 +243,37 @@ class UploadsControllerTest < ActionDispatch::IntegrationTest
end
should "fail for a .mp4 file encoded with h265" do
create_upload!("test/files/mp4/test-300x300.h265.mp4", user: @user)
create_upload!("test/files/mp4/test-300x300-h265.mp4", user: @user)
assert_match("File type is not supported", Upload.last.error)
end
should "fail for a .mp4 file encoded with av1" do
create_upload!("test/files/mp4/test-300x300.av1.mp4", user: @user)
create_upload!("test/files/mp4/test-300x300-av1.mp4", user: @user)
assert_match("File type is not supported", Upload.last.error)
end
should "fail for a 10-bit color .mp4 file encoded with av1" do
create_upload!("test/files/mp4/test-yuv420p10le-av1.mp4", user: @user)
assert_match("File type is not supported", Upload.last.error)
end
should "fail for a 10-bit color .mp4 file encoded with h264" do
create_upload!("test/files/mp4/test-yuv420p10le-h264.mp4", user: @user)
assert_match("File type is not supported", Upload.last.error)
end
should "fail for a 10-bit color .mp4 file encoded with vp9" do
create_upload!("test/files/mp4/test-yuv420p10le-vp9.mp4", user: @user)
assert_match("File type is not supported", Upload.last.error)
end
should "fail for a 4:4:4 subsampled .mp4 file" do
create_upload!("test/files/mp4/test-300x300-yuv444p-h264.mp4", user: @user)
assert_match("File type is not supported", Upload.last.error)
end
should "fail for a 10-bit color .webm file encoded with vp9" do
create_upload!("test/files/webm/test-yuv420p10le-vp9.webm", user: @user)
assert_match("File type is not supported", Upload.last.error)
end
end
@@ -335,7 +360,7 @@ class UploadsControllerTest < ActionDispatch::IntegrationTest
assert_equal([550, 368], full_variant.dimensions)
assert_equal(:jpg, full_variant.file_ext)
assert_equal(nil, media_asset.variant(:sample))
assert_nil(media_asset.variant(:sample))
end
end
@@ -345,10 +370,12 @@ class UploadsControllerTest < ActionDispatch::IntegrationTest
should_upload_successfully("test/files/test-static-32x32.gif")
should_upload_successfully("test/files/test-animated-86x52.gif")
should_upload_successfully("test/files/mp4/test-300x300.mp4")
should_upload_successfully("test/files/mp4/test-300x300.vp9.mp4")
should_upload_successfully("test/files/mp4/test-300x300-vp9.mp4")
should_upload_successfully("test/files/mp4/test-300x300-yuvj420p-h264.mp4")
should_upload_successfully("test/files/mp4/test-audio.mp4")
should_upload_successfully("test/files/mp4/test-audio.m4v")
should_upload_successfully("test/files/webm/test-512x512.webm")
should_upload_successfully("test/files/webm/test-gbrp-vp9.webm")
# should_upload_successfully("test/files/compressed.swf")
should_upload_successfully("test/files/avif/fox.profile0.8bpc.yuv420.monochrome.avif")