From 716cdb0126ab425cbd1b4d4dcf5f95f9b09b2538 Mon Sep 17 00:00:00 2001 From: evazion Date: Wed, 27 Jan 2021 00:11:05 -0600 Subject: [PATCH] tests: fix broken tests. * Fix a broken Twitter profile image upload test. * Skip a broken DeviantArt flash file upload test (flash no longer supported by DeviantArt?) * Skip user upgrade tests when Stripe is not configured. --- test/functional/uploads_controller_test.rb | 2 +- test/functional/user_upgrades_controller_test.rb | 4 ++++ test/functional/webhooks_controller_test.rb | 1 + test/unit/sources/deviant_art_test.rb | 1 + 4 files changed, 7 insertions(+), 1 deletion(-) diff --git a/test/functional/uploads_controller_test.rb b/test/functional/uploads_controller_test.rb index 52c3b79b7..86c58c815 100644 --- a/test/functional/uploads_controller_test.rb +++ b/test/functional/uploads_controller_test.rb @@ -335,7 +335,7 @@ class UploadsControllerTest < ActionDispatch::IntegrationTest should_upload_successfully("https://twitter.com/noizave/status/875768175136317440") should_upload_successfully("https://pbs.twimg.com/media/DCdZ_FhUIAAYKFN?format=jpg&name=medium") - should_upload_successfully("https://pbs.twimg.com/profile_banners/1130156172399353857/1597419344/1500x500") + should_upload_successfully("https://pbs.twimg.com/profile_banners/2371694594/1581832507/1500x500") # XXX should_upload_successfully("https://video.twimg.com/tweet_video/EWHWVrmVcAAp4Vw.mp4") should_upload_successfully("https://www.weibo.com/5501756072/J2UNKfbqV") diff --git a/test/functional/user_upgrades_controller_test.rb b/test/functional/user_upgrades_controller_test.rb index 9dc90da51..eb7930e23 100644 --- a/test/functional/user_upgrades_controller_test.rb +++ b/test/functional/user_upgrades_controller_test.rb @@ -2,6 +2,10 @@ require 'test_helper' class UserUpgradesControllerTest < ActionDispatch::IntegrationTest context "The user upgrades controller" do + setup do + skip unless UserUpgrade.enabled? + end + context "new action" do should "render for a self upgrade to Gold" do @user = create(:user) diff --git a/test/functional/webhooks_controller_test.rb b/test/functional/webhooks_controller_test.rb index 9fb64d43a..c39d08d0a 100644 --- a/test/functional/webhooks_controller_test.rb +++ b/test/functional/webhooks_controller_test.rb @@ -10,6 +10,7 @@ class WebhooksControllerTest < ActionDispatch::IntegrationTest end def post_webhook(*args, metadata: {}, payment_status: "paid") + skip unless UserUpgrade.enabled? event = StripeMock.mock_webhook_event(*args, payment_status: payment_status, metadata: metadata) signature = generate_stripe_signature(event) headers = { "Stripe-Signature": signature } diff --git a/test/unit/sources/deviant_art_test.rb b/test/unit/sources/deviant_art_test.rb index 7ba9cf10d..d328183d5 100644 --- a/test/unit/sources/deviant_art_test.rb +++ b/test/unit/sources/deviant_art_test.rb @@ -275,6 +275,7 @@ module Sources context "The source for a non-downloadable flash file" do should "return working image url" do + skip @site = Sources::Strategies.find("https://www.deviantart.com/heartgear/art/SL-40v3-522007633") # md5: 6adf1a3d532f898f44cf9948cbc7db7d