jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

posts: fix double deletion bug.

Browse Source 
Fix a bug where, if a user a was deleting a post and they accidentally
clicked the delete button twice, it could create two flags.
This commit is contained in:
evazion
2022-09-24 23:27:06 -05:00
parent 361af6a4cb
commit 718c4d121b
8 changed files with 65 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
test/functional/post_flags_controller_test.rb
View File

@@ -7,7 +7,7 @@ class PostFlagsControllerTest < ActionDispatch::IntegrationTest
@flagger = create(:gold_user, id: 999, created_at: 2.weeks.ago)
@uploader = create(:mod_user, name: "chen", created_at: 2.weeks.ago)
@mod = create(:mod_user, name: "mod")
@post = create(:post, id: 101, is_flagged: true, uploader: @uploader)
@post = create(:post, id: 101, uploader: @uploader)
@post_flag = create(:post_flag, reason: "xxx", post: @post, creator: @flagger)
end
@@ -27,7 +27,7 @@ class PostFlagsControllerTest < ActionDispatch::IntegrationTest
context "index action" do
setup do
@other_flag = create(:post_flag, post: build(:post, is_flagged: true, tag_string: "touhou"))
@other_flag = create(:post_flag, post: create(:post, tag_string: "touhou"))
@unrelated_flag = create(:post_flag, reason: "poor quality")
end
@@ -129,12 +129,31 @@ class PostFlagsControllerTest < ActionDispatch::IntegrationTest
context "create action" do
should "create a new flag" do
assert_difference("PostFlag.count", 1) do
@post = create(:post)
post_auth post_flags_path, @flagger, params: { post_flag: { post_id: @post.id, reason: "xxx" }}, as: :javascript
assert_redirected_to PostFlag.last
assert_equal(true, @post.reload.is_flagged?)
end
@post = create(:post)
post_auth post_flags_path, @flagger, params: { post_flag: { post_id: @post.id, reason: "xxx" }}, as: :javascript
assert_redirected_to PostFlag.last
assert_equal(true, @post.reload.is_flagged?)
assert_equal(1, @post.flags.count)
end
should "not allow flagging a flagged post" do
@post = create(:post, is_flagged: true)
post_auth post_flags_path, @flagger, params: { post_flag: { post_id: @post.id, reason: "xxx" }}, as: :javascript
assert_response :success
assert_equal(true, @post.reload.is_flagged?)
assert_equal(0, @post.flags.count)
end
should "not allow flagging a deleted post" do
@post = create(:post, is_deleted: true)
post_auth post_flags_path, @flagger, params: { post_flag: { post_id: @post.id, reason: "xxx" }}, as: :javascript
assert_response :success
assert_equal(false, @post.reload.is_flagged?)
assert_equal(true, @post.reload.is_deleted?)
assert_equal(0, @post.flags.count)
end
end