From 748fdf33d42ccb4c7cde79acb4ad61b372ba160e Mon Sep 17 00:00:00 2001 From: evazion Date: Mon, 18 Oct 2021 05:59:31 -0500 Subject: [PATCH] uploads: don't autotag sound on videos. Don't automatically add the sound tag to videos. This was incorrect nearly 20% of the time because of silent audio tracks. This error rate is too high. https://danbooru.donmai.us/posts?tags=exif:Track2:AudioChannels+-sound https://danbooru.donmai.us/posts?tags=exif:Track1:AudioChannels+-sound --- app/logical/upload_service/utils.rb | 7 ------- 1 file changed, 7 deletions(-) diff --git a/app/logical/upload_service/utils.rb b/app/logical/upload_service/utils.rb index f5a219706..1092f70f9 100644 --- a/app/logical/upload_service/utils.rb +++ b/app/logical/upload_service/utils.rb @@ -17,17 +17,10 @@ class UploadService upload.image_height = media_file.height upload.validate!(:file) - upload.tag_string = "#{upload.tag_string} #{Utils.automatic_tags(media_file)}" MediaAsset.upload!(media_file) end - def automatic_tags(media_file) - tags = [] - tags << "sound" if media_file.has_audio? - tags.join(" ") - end - def get_file_for_upload(source_url, referer_url, file) return MediaFile.open(file) if file.present? raise "No file or source URL provided" if source_url.blank?