Refactor sources

app/logical/twitter_service.rb

@@ -1,21 +1,22 @@
 class TwitterService
+  extend Memoist
+
   def client
     raise "Twitter API keys not set" if Danbooru.config.twitter_api_key.nil?
 
-    @client ||= begin
-      rest_client = ::Twitter::REST::Client.new do |config|
-        config.consumer_key = Danbooru.config.twitter_api_key
-        config.consumer_secret = Danbooru.config.twitter_api_secret
-        if bearer_token = Cache.get("twitter-api-token")
-          config.bearer_token = bearer_token
-        end
+    rest_client = ::Twitter::REST::Client.new do |config|
+      config.consumer_key = Danbooru.config.twitter_api_key
+      config.consumer_secret = Danbooru.config.twitter_api_secret
+      if bearer_token = Cache.get("twitter-api-token")
+        config.bearer_token = bearer_token
       end
-
-      Cache.put("twitter-api-token", rest_client.bearer_token)
-
-      rest_client
     end
+
+    Cache.put("twitter-api-token", rest_client.bearer_token)
+
+    rest_client
   end
+  memoize :client
 
   def extract_urls_for_status(tweet)
     tweet.media.map do |obj|