Refactor sources

test/unit/sources/twitter_test.rb

@@ -2,79 +2,16 @@ require 'test_helper'
 
 module Sources
   class TwitterTest < ActiveSupport::TestCase
-    context "A video" do
-      setup do
-        skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
-        @site = Sources::Site.new("https://twitter.com/CincinnatiZoo/status/859073537713328129")
-        @site.get
-      end
-
-      should "get the image url" do
-        assert_equal("https://video.twimg.com/ext_tw_video/859073467769126913/pu/vid/1280x720/cPGgVROXHy3yrK6u.mp4", @site.image_url)
-      end
-    end
-
-    context "An animated gif" do
-      setup do
-        skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
-        @site = Sources::Site.new("https://twitter.com/DaniStrawberry1/status/859435334765088769")
-        @site.get
-      end
-
-      should "get the image url" do
-        assert_equal("https://video.twimg.com/tweet_video/C-1Tns7WsAAqvqn.mp4", @site.image_url)
-      end
-    end
-
-    context "A twitter summary card" do
-      setup do
-        skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
-        @site = Sources::Site.new("https://twitter.com/NatGeo/status/932700115936178177")
-        @site.get
-      end
-
-      should "get the image url" do
-        assert_equal("https://pmdvod.nationalgeographic.com/NG_Video/205/302/smpost_1510342850295.jpg", @site.image_url)
-      end
-    end
-
-    context "A twitter summary card from twitter" do
-      setup do
-        skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
-        @site = Sources::Site.new("https://twitter.com/masayasuf/status/870734961778630656/photo/1")
-        @site.get
-      end
-
-      should "get the image url" do
-        assert_equal("https://pbs.twimg.com/media/DBV40M2UIAAHYlt.jpg:orig", @site.image_url)
-      end
-    end
-
-    context "A twitter summary card from twitter with a :large image" do
-      setup do
-        skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
-        @site = Sources::Site.new("https://twitter.com/aranobu/status/817736083567820800")
-        @site.get
-      end
-
-      should "get the image url" do
-        assert_equal("https://pbs.twimg.com/media/C1kt72yVEAEGpOv.jpg:orig", @site.image_url)
-      end
-    end
-
     context "An extended tweet" do
       should "extract the correct image url" do
         skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
-        @site = Sources::Site.new("https://twitter.com/onsen_musume_jp/status/865534101918330881")
-        @site.get
-
+        @site = Sources::Strategies.find("https://twitter.com/onsen_musume_jp/status/865534101918330881")
         assert_equal(["https://pbs.twimg.com/media/DAL-ntWV0AEbhes.jpg:orig"], @site.image_urls)
       end
 
       should "extract all the image urls" do
         skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
-        @site = Sources::Site.new("https://twitter.com/aoimanabu/status/892370963630743552")
-        @site.get
+        @site = Sources::Strategies.find("https://twitter.com/aoimanabu/status/892370963630743552")
 
         urls = %w[
           https://pbs.twimg.com/media/DGJWp59UIAA_-en.jpg:orig
@@ -85,12 +22,72 @@ module Sources
         assert_equal(urls, @site.image_urls)
       end
     end
+    
+    context "A video" do
+      setup do
+        skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
+        @site = Sources::Strategies.find("https://twitter.com/CincinnatiZoo/status/859073537713328129")
+      end
+
+      should "get the image url" do
+        assert_equal("https://video.twimg.com/ext_tw_video/859073467769126913/pu/vid/1280x720/cPGgVROXHy3yrK6u.mp4", @site.image_url)
+      end
+    end
+
+    context "An animated gif" do
+      setup do
+        skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
+        @site = Sources::Strategies.find("https://twitter.com/DaniStrawberry1/status/859435334765088769")
+      end
+
+      should "get the image url" do
+        assert_equal("https://video.twimg.com/tweet_video/C-1Tns7WsAAqvqn.mp4", @site.image_url)
+      end
+    end
+
+    context "A twitter summary card" do
+      setup do
+        skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
+        @site = Sources::Strategies.find("https://twitter.com/NatGeo/status/932700115936178177")
+      end
+
+      should "get the image url" do
+        assert_equal("https://pmdvod.nationalgeographic.com/NG_Video/205/302/smpost_1510342850295.jpg", @site.image_url)
+      end
+    end
+
+    context "A twitter summary card from twitter" do
+      setup do
+        skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
+        @site = Sources::Strategies.find("https://twitter.com/masayasuf/status/870734961778630656/photo/1")
+      end
+
+      should "get the image url" do
+        skip "Find another url, the masayasuf tweet no longer exists"
+        assert_equal("https://pbs.twimg.com/media/DBV40M2UIAAHYlt.jpg:orig", @site.image_url)
+      end
+    end
+
+    context "A twitter summary card from twitter with a :large image" do
+      setup do
+        skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
+        @site = Sources::Strategies.find("https://twitter.com/aranobu/status/817736083567820800")
+      end
+
+      should "get the image url" do
+        assert_equal("https://pbs.twimg.com/media/C1kt72yVEAEGpOv.jpg:orig", @site.image_url)
+      end
+
+      should "get the canonical url" do
+        assert_equal("https://twitter.com/aranobu/status/817736083567820800", @site.canonical_url)
+      end
+    end
 
     context "The source site for a restricted twitter" do
       setup do
         skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
-        @site = Sources::Site.new("https://mobile.twitter.com/Strangestone/status/556440271961858051")
-        @site.get
+        @site = Sources::Strategies.find("https://mobile.twitter.com/Strangestone/status/556440271961858051")
+        
       end
 
       should "get the image url" do
@@ -101,8 +98,7 @@ module Sources
     context "The source site for twitter" do
       setup do
         skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
-        @site = Sources::Site.new("https://mobile.twitter.com/nounproject/status/540944400767922176")
-        @site.get
+        @site = Sources::Strategies.find("https://mobile.twitter.com/nounproject/status/540944400767922176")
       end
 
       should "get the profile" do
@@ -135,8 +131,7 @@ module Sources
     context "The source site for a direct image and a referer" do
       setup do
         skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
-        @site = Sources::Site.new("https://pbs.twimg.com/media/B4HSEP5CUAA4xyu.png:large", referer_url: "https://twitter.com/nounproject/status/540944400767922176")
-        @site.get
+        @site = Sources::Strategies.find("https://pbs.twimg.com/media/B4HSEP5CUAA4xyu.png:large", "https://twitter.com/nounproject/status/540944400767922176")
       end
 
       should "get the artist name" do
@@ -151,8 +146,7 @@ module Sources
     context "The source site for a https://twitter.com/i/web/status/:id url" do
       setup do
         skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
-        @site = Sources::Site.new("https://twitter.com/i/web/status/943446161586733056")
-        @site.get
+        @site = Sources::Strategies.find("https://twitter.com/i/web/status/943446161586733056")
       end
 
       should "fetch the source data" do
@@ -163,8 +157,7 @@ module Sources
     context "A tweet" do
       setup do
         skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
-        @site = Sources::Site.new("https://twitter.com/noizave/status/875768175136317440")
-        @site.get
+        @site = Sources::Strategies.find("https://twitter.com/noizave/status/875768175136317440")
       end
 
       should "convert urls, hashtags, and mentions to dtext" do