From 7723597675291aa32ab5dd37f0dcc58f8649e070 Mon Sep 17 00:00:00 2001 From: evazion Date: Sun, 16 Feb 2020 23:10:24 -0600 Subject: [PATCH] notes: drop unused undo_changes_by_user method. --- app/models/note.rb | 14 -------------- test/unit/note_test.rb | 26 -------------------------- 2 files changed, 40 deletions(-) diff --git a/app/models/note.rb b/app/models/note.rb index 9675cc440..0f0e1cff7 100644 --- a/app/models/note.rb +++ b/app/models/note.rb @@ -137,20 +137,6 @@ class Note < ApplicationRecord new_note.save end - def self.undo_changes_by_user(vandal_id) - transaction do - note_ids = NoteVersion.where(:updater_id => vandal_id).select("note_id").distinct.map(&:note_id) - NoteVersion.where(["updater_id = ?", vandal_id]).delete_all - note_ids.each do |note_id| - note = Note.find(note_id) - most_recent = note.versions.last - if most_recent - note.revert_to!(most_recent) - end - end - end - end - def self.available_includes [:post] end diff --git a/test/unit/note_test.rb b/test/unit/note_test.rb index ac652bf4d..dd995a5ed 100644 --- a/test/unit/note_test.rb +++ b/test/unit/note_test.rb @@ -163,32 +163,6 @@ class NoteTest < ActiveSupport::TestCase end end - context "when notes have been vandalized by one user" do - setup do - @vandal = FactoryBot.create(:user) - @note = FactoryBot.create(:note, :x => 5, :y => 5) - CurrentUser.scoped(@vandal, "127.0.0.1") do - @note.update(x: 10, y: 10) - end - end - - context "the act of undoing all changes by that user" do - should "revert any affected notes" do - assert_equal(2, NoteVersion.count) - assert_equal([1, 2], @note.versions.map(&:version)) - assert_equal([@user.id, @vandal.id], @note.versions.map(&:updater_id)) - travel(1.day) do - Note.undo_changes_by_user(@vandal.id) - end - @note.reload - assert_equal([1, 3], @note.versions.map(&:version)) - assert_equal([@user.id, @user.id], @note.versions.map(&:updater_id)) - assert_equal(5, @note.x) - assert_equal(5, @note.y) - end - end - end - context "searching for a note" do setup do @note = FactoryBot.create(:note, :body => "aaa")