fixes #1851
This commit is contained in:
@@ -4,7 +4,7 @@ class SessionsController < ApplicationController
|
|||||||
end
|
end
|
||||||
|
|
||||||
def create
|
def create
|
||||||
session_creator = SessionCreator.new(session, cookies, params[:name], params[:password], params[:remember])
|
session_creator = SessionCreator.new(session, cookies, params[:name], params[:password], params[:remember], request.ssl?)
|
||||||
|
|
||||||
if session_creator.authenticate
|
if session_creator.authenticate
|
||||||
url = params[:url] if params[:url] && params[:url].start_with?("/")
|
url = params[:url] if params[:url] && params[:url].start_with?("/")
|
||||||
|
|||||||
@@ -1,12 +1,13 @@
|
|||||||
class SessionCreator
|
class SessionCreator
|
||||||
attr_reader :session, :cookies, :name, :password, :remember
|
attr_reader :session, :cookies, :name, :password, :remember, :secure
|
||||||
|
|
||||||
def initialize(session, cookies, name, password, remember)
|
def initialize(session, cookies, name, password, remember = false, secure = false)
|
||||||
@session = session
|
@session = session
|
||||||
@cookies = cookies
|
@cookies = cookies
|
||||||
@name = name
|
@name = name
|
||||||
@password = password
|
@password = password
|
||||||
@remember = remember
|
@remember = remember
|
||||||
|
@secure = secure
|
||||||
end
|
end
|
||||||
|
|
||||||
def authenticate
|
def authenticate
|
||||||
@@ -15,8 +16,15 @@ class SessionCreator
|
|||||||
user.update_column(:last_logged_in_at, Time.now)
|
user.update_column(:last_logged_in_at, Time.now)
|
||||||
|
|
||||||
if remember.present?
|
if remember.present?
|
||||||
cookies.permanent.signed[:user_name] = user.name
|
cookies.permanent.signed[:user_name] = {
|
||||||
cookies.permanent[:password_hash] = user.bcrypt_cookie_password_hash
|
:value => user.name,
|
||||||
|
:secure => secure
|
||||||
|
}
|
||||||
|
cookies.permanent[:password_hash] = {
|
||||||
|
:value => user.bcrypt_cookie_password_hash,
|
||||||
|
:secure => secure,
|
||||||
|
:httponly => true
|
||||||
|
}
|
||||||
end
|
end
|
||||||
|
|
||||||
session[:user_id] = user.id
|
session[:user_id] = user.id
|
||||||
|
|||||||
Reference in New Issue
Block a user