jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #5159 from nonamethanks/fix-furaffinity-ascii-urls

Browse Source 
Furaffinity: fix uploads for non-ascii image urls
This commit is contained in:
evazion
2022-05-09 14:16:32 -05:00
committed by GitHub
parent 638c928c8a 5b8402751c
commit 80f3778616
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/logical/source/extractor/furaffinity.rb
View File

@@ -19,7 +19,7 @@ class Source::Extractor
download_button = html_response&.css(".submission-content .auto_link .button").to_a.find { |el| el.text == "Download" } download_button = html_response&.css(".submission-content .auto_link .button").to_a.find { |el| el.text == "Download" }
partial_image = download_button&.[]("href") partial_image = download_button&.[]("href")
return [] unless partial_image.present? return [] unless partial_image.present?
[URI.join("https://d.furaffinity.net", partial_image).to_s].compact [Addressable::URI.join("https://d.furaffinity.net", partial_image).to_s].compact
end end
end end

7
test/unit/sources/furaffinity_test.rb
View File

@@ -42,6 +42,13 @@ module Sources
strategy_should_work("https://www.furaffinity.net/view/3404111", deleted: true, profile_url: nil) strategy_should_work("https://www.furaffinity.net/view/3404111", deleted: true, profile_url: nil)
end end
context "A furaffinity post with non-ascii image url" do
strategy_should_work(
"https://www.furaffinity.net/view/20762907/",
image_urls: ["https://d.furaffinity.net/art/fhedge/1470365580/1470365580.fhedge_ミストランサーまとめアートボード_1.jpg"]
)
end
should "Parse Furaffinity URLs correctly" do should "Parse Furaffinity URLs correctly" do
assert(Source::URL.image_url?("https://d.furaffinity.net/art/iwbitu/1650222955/1650222955.iwbitu_yubi.jpg")) assert(Source::URL.image_url?("https://d.furaffinity.net/art/iwbitu/1650222955/1650222955.iwbitu_yubi.jpg"))
assert(Source::URL.page_url?("https://www.furaffinity.net/view/46821705/")) assert(Source::URL.page_url?("https://www.furaffinity.net/view/46821705/"))