From 85a39cadf05cff3f4dfa58ba53b4f4158714851c Mon Sep 17 00:00:00 2001 From: evazion Date: Wed, 29 Mar 2017 13:46:27 -0500 Subject: [PATCH] /wiki_pages: avoid unnecessary COUNT(*). @wiki_pages.count issues a COUNT(*), which is unnecessary when we're just counting the ~20 @wiki_pages we've already loaded. --- app/controllers/wiki_pages_controller.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/controllers/wiki_pages_controller.rb b/app/controllers/wiki_pages_controller.rb index 96b92d4ad..abcbe42c2 100644 --- a/app/controllers/wiki_pages_controller.rb +++ b/app/controllers/wiki_pages_controller.rb @@ -19,9 +19,9 @@ class WikiPagesController < ApplicationController respond_with(@wiki_pages) do |format| format.html do if params[:page].nil? || params[:page].to_i == 1 - if @wiki_pages.count == 1 + if @wiki_pages.length == 1 redirect_to(wiki_page_path(@wiki_pages.first)) - elsif @wiki_pages.count == 0 && params[:search][:title].present? && params[:search][:title] !~ /\*/ + elsif @wiki_pages.length == 0 && params[:search][:title].present? && params[:search][:title] !~ /\*/ redirect_to(wiki_pages_path(:search => {:title => "*#{params[:search][:title]}*"})) end end