From 85ae2cda0d074f510de1d696846d9a0b9a23e0a2 Mon Sep 17 00:00:00 2001
From: evazion <noizave@gmail.com>
Date: Thu, 23 Aug 2018 15:21:51 -0500
Subject: [PATCH] optimization: prefer `relation.none` over
 `relation.where("false")`

Using `relation.none` instead of `relation.where("false")` avoids an sql query.
---
 app/logical/post_sets/artist.rb | 2 +-
 app/models/comment.rb           | 2 +-
 app/models/post_archive.rb      | 2 +-
 app/models/post_flag.rb         | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/logical/post_sets/artist.rb b/app/logical/post_sets/artist.rb
index 0d54785f9..6a2180407 100644
--- a/app/logical/post_sets/artist.rb
+++ b/app/logical/post_sets/artist.rb
@@ -14,7 +14,7 @@ module PostSets
         query
       end
     rescue ::Post::SearchError
-      ::Post.where("false")
+      ::Post.none
     end
 
     def presenter
diff --git a/app/models/comment.rb b/app/models/comment.rb
index 0a7fcbfb6..4c3242e03 100644
--- a/app/models/comment.rb
+++ b/app/models/comment.rb
@@ -64,7 +64,7 @@ class Comment < ApplicationRecord
     end
 
     def for_creator(user_id)
-      user_id.present? ? where("creator_id = ?", user_id) : where("false")
+      user_id.present? ? where("creator_id = ?", user_id) : none
     end
 
     def for_creator_name(user_name)
diff --git a/app/models/post_archive.rb b/app/models/post_archive.rb
index e31737fd2..37bf99eb3 100644
--- a/app/models/post_archive.rb
+++ b/app/models/post_archive.rb
@@ -22,7 +22,7 @@ class PostArchive < ApplicationRecord
       if user_id
         where("updater_id = ?", user_id)
       else
-        where("false")
+        none
       end
     end
 
diff --git a/app/models/post_flag.rb b/app/models/post_flag.rb
index 7411f9724..72a49b975 100644
--- a/app/models/post_flag.rb
+++ b/app/models/post_flag.rb
@@ -76,7 +76,7 @@ class PostFlag < ApplicationRecord
           q = q.where.not(post_id: CurrentUser.user.posts)
           q = q.where("creator_id = ?", params[:creator_id].to_i)
         else
-          q = q.where("false")
+          q = q.none
         end
       end
 
@@ -86,7 +86,7 @@ class PostFlag < ApplicationRecord
           q = q.where.not(post_id: CurrentUser.user.posts)
           q = q.where("creator_id = ?", flagger_id)
         else
-          q = q.where("false")
+          q = q.none
         end
       end