From 85f464df83830ad7b07bfdeb801f550205cf93bf Mon Sep 17 00:00:00 2001 From: evazion Date: Mon, 13 Jul 2020 18:42:44 -0500 Subject: [PATCH] Fix #4540: Demotion sends "You have been promoted" dmail. Change message to "Your account has been updated". It's possible for a user to both gain and lose permissions at the same time, so just say their account has been updated to make it easier. --- app/logical/user_promotion.rb | 6 +----- test/unit/user_test.rb | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/app/logical/user_promotion.rb b/app/logical/user_promotion.rb index 8f46ba0f0..b3b7a32bb 100644 --- a/app/logical/user_promotion.rb +++ b/app/logical/user_promotion.rb @@ -88,11 +88,7 @@ class UserPromotion end def create_dmail - Dmail.create_automated( - :to_id => user.id, - :title => "You have been promoted", - :body => build_messages - ) + Dmail.create_automated(to_id: user.id, title: "Your account has been updated", body: build_messages) end def create_user_feedback diff --git a/test/unit/user_test.rb b/test/unit/user_test.rb index 79fac4cda..36d34af45 100644 --- a/test/unit/user_test.rb +++ b/test/unit/user_test.rb @@ -34,7 +34,7 @@ class UserTest < ActiveSupport::TestCase @user.promote_to!(User::Levels::GOLD) end - assert(@user.dmails.exists?(from: bot, to: @user, title: "You have been promoted")) + assert(@user.dmails.exists?(from: bot, to: @user, title: "Your account has been updated")) refute(@user.dmails.exists?(from: bot, to: @user, title: "Your user record has been updated")) end end