jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix #4314: Favorite/vote modes give generic error messages.

Browse Source 
Refactor tag scripts to fix multiple issues:

* Errors during tag scripting didn't show the actual error message, just
  a generic "There was an error updating post #NNN" message.
* The quick edit form didn't show any error messages at all on failure.
* Thumbnails didn't have all their data attributes properly updated
  after the post was updated.

This changes it so that thumbnails have their html fully replaced after
updating. This has the side effect of removing event handlers bound
directly to the thumbnail. A `danbooru:post-preview-updated` event is
fired in case userscripts need to detect when thumbnails are updated.
This commit is contained in:
evazion
2020-02-27 18:49:08 -06:00
parent dd2faa0d35
commit 869142ed1b
5 changed files with 42 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
app/javascript/src/javascripts/post_mode_menu.js
View File

@@ -57,36 +57,21 @@ PostModeMenu.initialize_selector = function() {
}
PostModeMenu.initialize_preview_link = function() {
$(".post-preview a").on("click.danbooru", PostModeMenu.click);
$(document).on("click.danbooru", ".post-preview a", PostModeMenu.click);
}
PostModeMenu.initialize_edit_form = function() {
$("#quick-edit-div").hide();
$("#quick-edit-form input[value=Cancel]").on("click.danbooru", function(e) {
$(document).on("click.danbooru", "#quick-edit-form button[name=cancel]", function(e) {
PostModeMenu.close_edit_form();
e.preventDefault();
});
$("#quick-edit-form").on("submit.danbooru", function(e) {
$.ajax({
type: "put",
url: $("#quick-edit-form").attr("action"),
data: {
post: {
tag_string: $("#post_tag_string").val()
}
},
complete: function() {
$.rails.enableFormElements($("#quick-edit-form"));
},
success: function(data) {
Post.update_data(data);
Utility.notice("Post #" + data.id + " updated");
PostModeMenu.close_edit_form();
}
});
$(document).on("click.danbooru", "#quick-edit-form input[type=submit]", async function(e) {
e.preventDefault();
let post_id = $("#quick-edit-form").data("post-id");
await Post.update(post_id, "quick-edit", { post: { tag_string: $("#post_tag_string").val() }});
});
}
@@ -140,7 +125,7 @@ PostModeMenu.change = function() {
PostModeMenu.open_edit = function(post_id) {
var $post = $("#post_" + post_id);
$("#quick-edit-div").slideDown("fast");
$("#quick-edit-form").attr("action", "/posts/" + post_id + ".json");
$("#quick-edit-form").attr("data-post-id", post_id);
$("#post_tag_string").val($post.data("tags") + " ").focus().selectEnd();
/* Set height of tag edit box to fit content. */