jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

BURs: remove dead error handling code.

Browse Source 
This is a 'this should never happen' error. This error is only raised if
we add a new bulk update request type and forget to handle it somewhere.
This commit is contained in:
evazion
2020-12-03 15:52:04 -06:00
parent 35d26e92e9
commit 8a52d8ed5f
2 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/models/bulk_update_request.rb
View File

@@ -72,11 +72,6 @@ class BulkUpdateRequest < ApplicationRecord
forum_updater.update("The #{bulk_update_request_link} (forum ##{forum_post.id}) has been approved by @#{approver.name}.") forum_updater.update("The #{bulk_update_request_link} (forum ##{forum_post.id}) has been approved by @#{approver.name}.")
end end
end end
rescue BulkUpdateRequestProcessor::Error => x
self.approver = approver
CurrentUser.scoped(approver) do
forum_updater.update("The #{bulk_update_request_link} (forum ##{forum_post.id}) has failed: #{x}")
end
end end
def create_forum_topic def create_forum_topic

4
test/unit/bulk_update_request_test.rb
View File

@@ -458,10 +458,6 @@ class BulkUpdateRequestTest < ActiveSupport::TestCase
should "gracefully handle validation errors during approval" do should "gracefully handle validation errors during approval" do
@req.stubs(:update!).raises(BulkUpdateRequestProcessor::Error.new("blah")) @req.stubs(:update!).raises(BulkUpdateRequestProcessor::Error.new("blah"))
assert_difference("ForumPost.count", 1) do
@req.approve!(@admin)
end
assert_equal("pending", @req.reload.status) assert_equal("pending", @req.reload.status)
end end