skip pixiv-related tests that throw networking errors

2018-05-14 11:02:22 -07:00
parent 8d5db3723b
commit 8b16934aaa
7 changed files with 143 additions and 101 deletions
--- a/test/functional/sources_controller_test.rb
+++ b/test/functional/sources_controller_test.rb
@@ -4,8 +4,12 @@ class SourcesControllerTest < ActionDispatch::IntegrationTest
  context "The sources controller" do
    context "show action" do
      should "work for a pixiv URL" do
-        get source_path, params: { url: "http://www.pixiv.net/member_illust.php?mode=medium&illust_id=14901720", format: "json" }
-        assert_response :success
+        begin
+          get source_path, params: { url: "http://www.pixiv.net/member_illust.php?mode=medium&illust_id=14901720", format: "json" }
+          assert_response :success
+        rescue Net::OpenTimeout
+          skip "Remote connection failed to Pixiv failed"
+        end
      end

      should "work for a direct twitter URL with referer" do