validations: drop superfluous return statements.

Returning true or false in a validation callback doesn't do anything, so drop these superfluous return statements.
2019-08-04 15:45:05 -05:00
parent a926b162be
commit 9163b3cb1c
16 changed files with 6 additions and 62 deletions
--- a/app/models/upload.rb
+++ b/app/models/upload.rb
@@ -255,10 +255,7 @@ class Upload < ApplicationRecord

  def uploader_is_not_limited
    if !uploader.can_upload?
-      self.errors.add(:uploader, uploader.upload_limited_reason)
-      return false
-    else
-      return true
+      errors.add(:uploader, uploader.upload_limited_reason)
    end
  end