Fix #4374: Unvoting comments is broken.

2020-03-28 21:15:51 -05:00
parent c5260f4927
commit 919a2868be
3 changed files with 35 additions and 2 deletions
--- a/app/controllers/comment_votes_controller.rb
+++ b/app/controllers/comment_votes_controller.rb
@@ -10,13 +10,13 @@ class CommentVotesController < ApplicationController
  end

  def create
-    @comment = authorize Comment.find(params[:comment_id])
+    @comment = authorize Comment.find(params[:comment_id]), policy_class: CommentVotePolicy
    @comment_vote = @comment.vote!(params[:score])
    respond_with(@comment)
  end

  def destroy
-    @comment = authorize Comment.find(params[:comment_id])
+    @comment = authorize Comment.find(params[:comment_id]), policy_class: CommentVotePolicy
    @comment.unvote!
    respond_with(@comment)
  end
--- a/app/policies/comment_vote_policy.rb
+++ b/app/policies/comment_vote_policy.rb
@@ -1,2 +1,6 @@
 class CommentVotePolicy < ApplicationPolicy
+  def destroy?
+    # XXX permissions are checked in Comment#unvote!
+    true
+  end
 end