/user_name_change_requests: fix renames not being visible to all users.
This commit is contained in:
@@ -12,7 +12,7 @@ class UserNameChangeRequest < ApplicationRecord
|
|||||||
if viewer.is_admin?
|
if viewer.is_admin?
|
||||||
all
|
all
|
||||||
elsif viewer.is_member?
|
elsif viewer.is_member?
|
||||||
joins(:user).merge(User.undeleted).where("user_name_change_requests.user_id = ?", viewer.id)
|
where(user: User.undeleted)
|
||||||
else
|
else
|
||||||
none
|
none
|
||||||
end
|
end
|
||||||
|
|||||||
@@ -45,8 +45,11 @@ class UserNameChangeRequestsControllerTest < ActionDispatch::IntegrationTest
|
|||||||
context "for actions restricted to admins" do
|
context "for actions restricted to admins" do
|
||||||
context "index action" do
|
context "index action" do
|
||||||
should "render" do
|
should "render" do
|
||||||
get_auth user_name_change_requests_path, @admin
|
post_auth user_name_change_requests_path, @user, params: { user_name_change_request: { desired_name: "zun", desired_name_confirmation: "zun" }}
|
||||||
|
get user_name_change_requests_path
|
||||||
|
|
||||||
assert_response :success
|
assert_response :success
|
||||||
|
assert_select "table tbody tr", 1
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|||||||
Reference in New Issue
Block a user