From 9b31e16627c64244a138f6b7d4a6063ebd50c660 Mon Sep 17 00:00:00 2001 From: evazion Date: Sun, 4 Jun 2017 14:02:46 -0500 Subject: [PATCH] mode menu: fix height of tag edit box in edit mode. Bug: in edit mode, each time you click a thumbnail the height of the tag edit box increases by 4px. This is due to `scrollHeight` including vertical padding. Fix it to a) ignore this padding, and b) ensure the min height is at least 80px. --- app/assets/javascripts/post_mode_menu.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/post_mode_menu.js b/app/assets/javascripts/post_mode_menu.js index db7e858b0..d3c85167a 100644 --- a/app/assets/javascripts/post_mode_menu.js +++ b/app/assets/javascripts/post_mode_menu.js @@ -138,7 +138,13 @@ var $post = $("#post_" + post_id); $("#quick-edit-div").slideDown("fast"); $("#quick-edit-form").attr("action", "/posts/" + post_id + ".json"); - $("#post_tag_string").val($post.data("tags") + " ").focus().selectEnd().height($("#post_tag_string")[0].scrollHeight); + $("#post_tag_string").val($post.data("tags") + " ").focus().selectEnd(); + + /* Set height of tag edit box to fit content. */ + $("#post_tag_string").height(80); // min height: 80px. + var padding = $("#post_tag_string").innerHeight() - $("#post_tag_string").height(); + var height = $("#post_tag_string").prop("scrollHeight") - padding; + $("#post_tag_string").height(height); } Danbooru.PostModeMenu.click = function(e) {