From 9cfb753c1b3a67aaac60c664c157d46ff987e1ee Mon Sep 17 00:00:00 2001 From: evazion Date: Wed, 30 Oct 2019 23:43:52 -0500 Subject: [PATCH] post tooltips: fix null deref when tooltips are disabled. Fix an exception that is triggered by mousing out of a thumbnail when tooltips are disabled. Caused by trying to access `qtip.cache` when `qtip` is null. --- app/javascript/src/javascripts/post_tooltips.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/javascript/src/javascripts/post_tooltips.js b/app/javascript/src/javascripts/post_tooltips.js index 028d777b9..4be1754ec 100644 --- a/app/javascript/src/javascripts/post_tooltips.js +++ b/app/javascript/src/javascripts/post_tooltips.js @@ -89,7 +89,7 @@ PostTooltip.initialize = function () { $(document).on("mouseleave.danbooru.postTooltip", PostTooltip.POST_SELECTOR, function (event) { let qtip = $(event.target).qtip("api"); - if (qtip.cache.request && qtip.cache.request.state() === "pending") { + if (qtip && qtip.cache && qtip.cache.request && qtip.cache.request.state() === "pending") { qtip.cache.request.abort(); } });