From a3278540175d52ae0a893ba9ddca3235b92f4727 Mon Sep 17 00:00:00 2001 From: evazion Date: Fri, 3 Feb 2017 01:56:11 -0600 Subject: [PATCH] Fix post_update_count increment test. 7) Failure: PostTest#test_: Tagging: A post that has been updated should increment the updater's post_update_count. [/home/danbooru/src/danbooru/test/unit/post_test.rb:1010]: "CurrentUser.post_update_count" didn't change by 1. Expected: 1 Actual: 3 --- app/models/post.rb | 2 ++ test/unit/post_test.rb | 9 ++++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/app/models/post.rb b/app/models/post.rb index 45f20ee49..1b9bda9cd 100644 --- a/app/models/post.rb +++ b/app/models/post.rb @@ -1436,6 +1436,8 @@ class Post < ActiveRecord::Base def create_new_version User.where(id: CurrentUser.id).update_all("post_update_count = post_update_count + 1") + CurrentUser.reload + versions.create( :rating => rating, :source => source, diff --git a/test/unit/post_test.rb b/test/unit/post_test.rb index 85442dc84..354b2d333 100644 --- a/test/unit/post_test.rb +++ b/test/unit/post_test.rb @@ -1,8 +1,10 @@ require 'test_helper' require 'helpers/pool_archive_test_helper' +require 'helpers/saved_search_test_helper' class PostTest < ActiveSupport::TestCase include PoolArchiveTestHelper + include SavedSearchTestHelper setup do Timecop.travel(2.weeks.ago) do @@ -12,6 +14,7 @@ class PostTest < ActiveSupport::TestCase CurrentUser.ip_addr = "127.0.0.1" MEMCACHE.flush_all Delayed::Worker.delay_jobs = false + mock_saved_search_service! end teardown do @@ -767,7 +770,7 @@ class PostTest < ActiveSupport::TestCase context "of" do setup do - @builder = FactoryGirl.build(:builder_user) + @builder = FactoryGirl.create(:builder_user) end context "locked:notes" do @@ -822,7 +825,7 @@ class PostTest < ActiveSupport::TestCase context "by an admin" do should "lock/unlock the status" do - CurrentUser.scoped(FactoryGirl.build(:admin_user)) do + CurrentUser.scoped(FactoryGirl.create(:admin_user)) do @post.update(:tag_string => "locked:status") assert_equal(true, @post.is_status_locked) @@ -836,7 +839,7 @@ class PostTest < ActiveSupport::TestCase context "of" do setup do - @gold = FactoryGirl.build(:gold_user) + @gold = FactoryGirl.create(:gold_user) end context "upvote:self or downvote:self" do