Add tests for all models with includes searches

test/functional/artist_urls_controller_test.rb

@@ -2,28 +2,24 @@ require 'test_helper'
 
 class ArtistUrlsControllerTest < ActionDispatch::IntegrationTest
   context "The artist urls controller" do
+    setup do
+      @artist = create(:artist, name: "bkub", url_string: "-http://bkub.com")
+      @banned = create(:artist, name: "danbo", is_banned: true, url_string: "https://danbooru.donmai.us")
+    end
+
     context "index page" do
       should "render" do
         get artist_urls_path
         assert_response :success
       end
 
-      should "render for a json request" do
-        get artist_urls_path, as: :json
-        assert_response :success
-      end
+      should respond_to_search({}).with { @banned.urls + @artist.urls }
+      should respond_to_search(url_matches: "*bkub*").with { @artist.urls }
+      should respond_to_search(is_active: "false").with { @artist.urls }
 
-      should "render for a complex search" do
-        @artist = FactoryBot.create(:artist, name: "bkub", url_string: "-http://bkub.com")
-
-        get artist_urls_path(search: {
-          artist: { name: "bkub" },
-          url_matches: "*bkub*",
-          is_active: "false",
-          order: "created_at"
-        })
-
-        assert_response :success
+      context "using includes" do
+        should respond_to_search(artist: {name: "bkub"}).with { @artist.urls }
+        should respond_to_search(artist: {is_banned: "true"}).with { @banned.urls }
       end
     end
   end