models: drop unnecessary presence validations.

In rails 5, belongs_to associations automatically validate that the
associated item is present, meaning that we don't need to validate these
things manually any more.
This commit is contained in:
evazion
2019-08-04 14:40:37 -05:00
parent 7c8c4e9f82
commit a926b162be
16 changed files with 11 additions and 36 deletions

View File

@@ -5,8 +5,7 @@ class Note < ApplicationRecord
belongs_to :post
belongs_to_creator
has_many :versions, -> {order("note_versions.id ASC")}, :class_name => "NoteVersion", :dependent => :destroy
validates_presence_of :creator_id, :x, :y, :width, :height, :body
validate :post_must_exist
validates_presence_of :x, :y, :width, :height, :body
validate :note_within_image
after_save :update_post
after_save :create_version
@@ -68,13 +67,6 @@ class Note < ApplicationRecord
extend SearchMethods
include ApiMethods
def post_must_exist
if !Post.exists?(post_id)
errors.add :post, "must exist"
return false
end
end
def post_must_not_be_note_locked
if is_locked?
errors.add :post, "is note locked"