Move more logic to the helper modules
- Diff view changes -- Only show pool description changes in diff view -- Conditionally render diff link when applicable values are changed -- Conditionally show diff view sections when values are changed - Show renames on index view -- There is plenty of space -- This wasn't shown at all for wikis -- Having to navigate to an alternate page is unwieldy for pools - Show "posts" as a status on pools -- This is so all changes among versions are quantified as a status - Standardize diff/index titles
This commit is contained in:
@@ -1,19 +1,48 @@
|
||||
module PostVersionsHelper
|
||||
def post_version_diff(post_version)
|
||||
diff = post_version.diff(post_version.previous)
|
||||
previous = post_version.previous
|
||||
post = post_version.post
|
||||
|
||||
if post.nil?
|
||||
latest_tags = post_version.tag_array
|
||||
else
|
||||
latest_tags = post.tag_array
|
||||
latest_tags << "rating:#{post.rating}" if post.rating.present?
|
||||
latest_tags << "parent:#{post.parent_id}" if post.parent_id.present?
|
||||
latest_tags << "source:#{post.source}" if post.source.present?
|
||||
end
|
||||
|
||||
new_tags = post_version.tag_array
|
||||
new_tags << "rating:#{post_version.rating}" if post_version.rating.present?
|
||||
new_tags << "parent:#{post_version.parent_id}" if post_version.parent_id.present?
|
||||
new_tags << "source:#{post_version.source}" if post_version.source.present?
|
||||
|
||||
old_tags = previous.present? ? previous.tag_array : []
|
||||
if previous.present?
|
||||
old_tags << "rating:#{previous.rating}" if previous.rating.present?
|
||||
old_tags << "parent:#{previous.parent_id}" if previous.parent_id.present?
|
||||
old_tags << "source:#{previous.source}" if previous.source.present?
|
||||
end
|
||||
|
||||
added_tags = new_tags - old_tags
|
||||
removed_tags = old_tags - new_tags
|
||||
obsolete_added_tags = added_tags - latest_tags,
|
||||
obsolete_removed_tags = removed_tags & latest_tags,
|
||||
unchanged_tags = new_tags & old_tags
|
||||
|
||||
html = '<span class="diff-list">'
|
||||
|
||||
diff[:added_tags].each do |tag|
|
||||
prefix = diff[:obsolete_added_tags].include?(tag) ? '+<ins class="obsolete">' : '<ins>+'
|
||||
added_tags.each do |tag|
|
||||
prefix = obsolete_added_tags.include?(tag) ? '+<ins class="obsolete">' : '<ins>+'
|
||||
html << prefix + link_to(wordbreakify(tag), posts_path(:tags => tag)) + '</ins>'
|
||||
html << " "
|
||||
end
|
||||
diff[:removed_tags].each do |tag|
|
||||
prefix = diff[:obsolete_removed_tags].include?(tag) ? '-<del class="obsolete">' : '<del>-'
|
||||
removed_tags.each do |tag|
|
||||
prefix = obsolete_removed_tags.include?(tag) ? '-<del class="obsolete">' : '<del>-'
|
||||
html << prefix + link_to(wordbreakify(tag), posts_path(:tags => tag)) + '</del>'
|
||||
html << " "
|
||||
end
|
||||
diff[:unchanged_tags].each do |tag|
|
||||
unchanged_tags.each do |tag|
|
||||
html << '<span>' + link_to(wordbreakify(tag), posts_path(:tags => tag)) + '</span>'
|
||||
html << " "
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user