Raise error on unpermitted params.

Fail loudly if we forget to whitelist a param instead of silently
ignoring it.

misc models: convert to strong params.

artist commentaries: convert to strong params.

* Disallow changing or setting post_id to a nonexistent post.

artists: convert to strong params.

* Disallow setting `is_banned` in create/update actions. Changing it
  this way instead of with the ban/unban actions would leave the artist in
  a partially banned state.

bans: convert to strong params.

* Disallow changing the user_id after the ban has been created.

comments: convert to strong params.

favorite groups: convert to strong params.

news updates: convert to strong params.

post appeals: convert to strong params.

post flags: convert to strong params.

* Disallow users from setting the `is_deleted` / `is_resolved` flags.

ip bans: convert to strong params.

user feedbacks: convert to strong params.

* Disallow users from setting `disable_dmail_notification` when creating feedbacks.
* Disallow changing the user_id after the feedback has been created.

notes: convert to strong params.

wiki pages: convert to strong params.

* Also fix non-Builders being able to delete wiki pages.

saved searches: convert to strong params.

pools: convert to strong params.

* Disallow setting `post_count` or `is_deleted` in create/update actions.

janitor trials: convert to strong params.

post disapprovals: convert to strong params.

* Factor out quick-mod bar to shared partial.
* Fix quick-mod bar to use `Post#is_approvable?` to determine visibility
  of Approve button.

dmail filters: convert to strong params.

password resets: convert to strong params.

user name change requests: convert to strong params.

posts: convert to strong params.

users: convert to strong params.

* Disallow setting password_hash, last_logged_in_at, last_forum_read_at,
  has_mail, and dmail_filter_attributes[user_id].

* Remove initialize_default_image_size (dead code).

uploads: convert to strong params.

* Remove `initialize_status` because status already defaults to pending
  in the database.

tag aliases/implications: convert to strong params.

tags: convert to strong params.

forum posts: convert to strong params.

* Disallow changing the topic_id after creating the post.
* Disallow setting is_deleted (destroy/undelete actions should be used instead).
* Remove is_sticky / is_locked (nonexistent attributes).

forum topics: convert to strong params.

* merges https://github.com/evazion/danbooru/tree/wip-rails-5.1
* lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4)
* switch to factorybot and change all references

Co-authored-by: r888888888 <r888888888@gmail.com>
Co-authored-by: evazion <noizave@gmail.com>

add diffs

app/controllers/bans_controller.rb

@@ -1,6 +1,7 @@
 class BansController < ApplicationController
-  before_filter :moderator_only, :except => [:show, :index]
+  before_action :moderator_only, :except => [:show, :index]
   respond_to :html, :xml, :json
+  helper_method :search_params
 
   def new
     @ban = Ban.new(params[:ban])
@@ -11,7 +12,7 @@ class BansController < ApplicationController
   end
 
   def index
-    @bans = Ban.search(params[:search]).paginate(params[:page], :limit => params[:limit])
+    @bans = Ban.search(search_params).paginate(params[:page], :limit => params[:limit])
     respond_with(@bans) do |fmt|
       fmt.html { @bans = @bans.includes(:user, :banner) }
     end
@@ -23,7 +24,7 @@ class BansController < ApplicationController
   end
 
   def create
-    @ban = Ban.create(params[:ban])
+    @ban = Ban.create(ban_params(:create))
 
     if @ban.errors.any?
       render :action => "new"
@@ -34,7 +35,7 @@ class BansController < ApplicationController
 
   def update
     @ban = Ban.find(params[:id])
-    if @ban.update_attributes(params[:ban])
+    if @ban.update(ban_params(:update))
       redirect_to ban_path(@ban), :notice => "Ban updated"
     else
       render :action => "edit"
@@ -46,4 +47,13 @@ class BansController < ApplicationController
     @ban.destroy
     redirect_to bans_path, :notice => "Ban destroyed"
   end
+
+  private
+
+  def ban_params(context)
+    permitted_params = %i[reason duration expires_at]
+    permitted_params += %i[user_id user_name] if context == :create
+
+    params.require(:ban).permit(permitted_params)
+  end
 end