Raise error on unpermitted params.

Fail loudly if we forget to whitelist a param instead of silently
ignoring it.

misc models: convert to strong params.

artist commentaries: convert to strong params.

* Disallow changing or setting post_id to a nonexistent post.

artists: convert to strong params.

* Disallow setting `is_banned` in create/update actions. Changing it
  this way instead of with the ban/unban actions would leave the artist in
  a partially banned state.

bans: convert to strong params.

* Disallow changing the user_id after the ban has been created.

comments: convert to strong params.

favorite groups: convert to strong params.

news updates: convert to strong params.

post appeals: convert to strong params.

post flags: convert to strong params.

* Disallow users from setting the `is_deleted` / `is_resolved` flags.

ip bans: convert to strong params.

user feedbacks: convert to strong params.

* Disallow users from setting `disable_dmail_notification` when creating feedbacks.
* Disallow changing the user_id after the feedback has been created.

notes: convert to strong params.

wiki pages: convert to strong params.

* Also fix non-Builders being able to delete wiki pages.

saved searches: convert to strong params.

pools: convert to strong params.

* Disallow setting `post_count` or `is_deleted` in create/update actions.

janitor trials: convert to strong params.

post disapprovals: convert to strong params.

* Factor out quick-mod bar to shared partial.
* Fix quick-mod bar to use `Post#is_approvable?` to determine visibility
  of Approve button.

dmail filters: convert to strong params.

password resets: convert to strong params.

user name change requests: convert to strong params.

posts: convert to strong params.

users: convert to strong params.

* Disallow setting password_hash, last_logged_in_at, last_forum_read_at,
  has_mail, and dmail_filter_attributes[user_id].

* Remove initialize_default_image_size (dead code).

uploads: convert to strong params.

* Remove `initialize_status` because status already defaults to pending
  in the database.

tag aliases/implications: convert to strong params.

tags: convert to strong params.

forum posts: convert to strong params.

* Disallow changing the topic_id after creating the post.
* Disallow setting is_deleted (destroy/undelete actions should be used instead).
* Remove is_sticky / is_locked (nonexistent attributes).

forum topics: convert to strong params.

* merges https://github.com/evazion/danbooru/tree/wip-rails-5.1
* lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4)
* switch to factorybot and change all references

Co-authored-by: r888888888 <r888888888@gmail.com>
Co-authored-by: evazion <noizave@gmail.com>

add diffs

app/controllers/maintenance/user/api_keys_controller.rb

@@ -1,8 +1,8 @@
 module Maintenance
   module User
     class ApiKeysController < ApplicationController
-      before_filter :check_privilege
-      before_filter :authenticate!, :except => [:show]
+      before_action :check_privilege
+      before_action :authenticate!, :except => [:show]
       rescue_from ::SessionLoader::AuthenticationFailure, :with => :authentication_failed
       respond_to :html, :json, :xml
 

app/controllers/maintenance/user/dmail_filters_controller.rb

@@ -1,7 +1,7 @@
 module Maintenance
   module User
     class DmailFiltersController < ApplicationController
-      before_filter :ensure_ownership
+      before_action :ensure_ownership
       respond_to :html, :json, :xml
 
       def edit
@@ -10,12 +10,12 @@ module Maintenance
 
       def update
         @dmail_filter = CurrentUser.dmail_filter || DmailFilter.new
-        @dmail_filter.update(params.require(:dmail_filter).permit(:words), :as => CurrentUser.role)
+        @dmail_filter.update(dmail_filter_params)
         flash[:notice] = "Filter updated"
         respond_with(@dmail)
       end
 
-    private
+      private
 
       def ensure_ownership
         @dmail = Dmail.find(params[:dmail_id])
@@ -24,6 +24,10 @@ module Maintenance
           raise User::PrivilegeError.new
         end
       end
+
+      def dmail_filter_params
+        params.require(:dmail_filter).permit(:words)
+      end
     end
   end
 end

app/controllers/maintenance/user/email_notifications_controller.rb

@@ -3,7 +3,7 @@ module Maintenance
     class EmailNotificationsController < ApplicationController
       class VerificationError < Exception ; end
 
-      before_filter :validate_sig, :only => [:destroy]
+      before_action :validate_sig, :only => [:destroy]
       rescue_from VerificationError, :with => :render_403
 
       def show
@@ -18,7 +18,7 @@ module Maintenance
     private
 
       def render_403
-        render :nothing => true, :status => 403
+        render plain: "", :status => 403
       end
 
       def validate_sig

app/controllers/maintenance/user/password_resets_controller.rb

@@ -6,7 +6,7 @@ module Maintenance
       end
 
       def create
-        @nonce = UserPasswordResetNonce.create(params[:nonce])
+        @nonce = UserPasswordResetNonce.create(nonce_params)
         if @nonce.errors.any?
           redirect_to new_maintenance_user_password_reset_path, :notice => @nonce.errors.full_messages.join("; ")
         else
@@ -29,6 +29,10 @@ module Maintenance
           redirect_to new_maintenance_user_password_reset_path, :notice => "Invalid key"
         end
       end
+
+      def nonce_params
+        params.fetch(:nonce, {}).permit([:email])
+      end
     end
   end
 end