Raise error on unpermitted params.

Fail loudly if we forget to whitelist a param instead of silently
ignoring it.

misc models: convert to strong params.

artist commentaries: convert to strong params.

* Disallow changing or setting post_id to a nonexistent post.

artists: convert to strong params.

* Disallow setting `is_banned` in create/update actions. Changing it
  this way instead of with the ban/unban actions would leave the artist in
  a partially banned state.

bans: convert to strong params.

* Disallow changing the user_id after the ban has been created.

comments: convert to strong params.

favorite groups: convert to strong params.

news updates: convert to strong params.

post appeals: convert to strong params.

post flags: convert to strong params.

* Disallow users from setting the `is_deleted` / `is_resolved` flags.

ip bans: convert to strong params.

user feedbacks: convert to strong params.

* Disallow users from setting `disable_dmail_notification` when creating feedbacks.
* Disallow changing the user_id after the feedback has been created.

notes: convert to strong params.

wiki pages: convert to strong params.

* Also fix non-Builders being able to delete wiki pages.

saved searches: convert to strong params.

pools: convert to strong params.

* Disallow setting `post_count` or `is_deleted` in create/update actions.

janitor trials: convert to strong params.

post disapprovals: convert to strong params.

* Factor out quick-mod bar to shared partial.
* Fix quick-mod bar to use `Post#is_approvable?` to determine visibility
  of Approve button.

dmail filters: convert to strong params.

password resets: convert to strong params.

user name change requests: convert to strong params.

posts: convert to strong params.

users: convert to strong params.

* Disallow setting password_hash, last_logged_in_at, last_forum_read_at,
  has_mail, and dmail_filter_attributes[user_id].

* Remove initialize_default_image_size (dead code).

uploads: convert to strong params.

* Remove `initialize_status` because status already defaults to pending
  in the database.

tag aliases/implications: convert to strong params.

tags: convert to strong params.

forum posts: convert to strong params.

* Disallow changing the topic_id after creating the post.
* Disallow setting is_deleted (destroy/undelete actions should be used instead).
* Remove is_sticky / is_locked (nonexistent attributes).

forum topics: convert to strong params.

* merges https://github.com/evazion/danbooru/tree/wip-rails-5.1
* lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4)
* switch to factorybot and change all references

Co-authored-by: r888888888 <r888888888@gmail.com>
Co-authored-by: evazion <noizave@gmail.com>

add diffs

test/functional/bans_controller_test.rb

@@ -1,50 +1,50 @@
 require 'test_helper'
 
-class BansControllerTest < ActionController::TestCase
+class BansControllerTest < ActionDispatch::IntegrationTest
   context "A bans controller" do
     setup do
-      @mod = FactoryGirl.create(:moderator_user)
-      CurrentUser.user = @mod
-      CurrentUser.ip_addr = "127.0.0.1"
-      @user = FactoryGirl.create(:user)
-      @ban = FactoryGirl.create(:ban, :user_id => @user.id)
-    end
-
-    teardown do
-      CurrentUser.user = nil
-      CurrentUser.ip_addr = nil
+      @mod = create(:moderator_user)
+      @user = create(:user)
+      as(@mod) do
+        @ban = create(:ban, user: @user)
+      end
     end
 
     should "get the new page" do
-      get :new, {}, {:user_id => @mod.id}
+      get_auth new_ban_path, @mod
       assert_response :success
     end
 
     should "get the edit page" do
-      get :edit, {:id => @ban.id}, {:user_id => @mod.id}
+      get_auth edit_ban_path(@ban.id), @mod
       assert_response :success
     end
 
     should "get the show page" do
-      get :show, {:id => @ban.id}
+      get_auth ban_path(@ban.id), @mod
       assert_response :success
     end
 
     should "get the index page" do
-      get :index
+      get_auth bans_path, @mod
+      assert_response :success
+    end
+
+    should "search" do
+      get_auth bans_path(search: {user_name: @user.name}), @mod
       assert_response :success
     end
 
     should "create a ban" do
       assert_difference("Ban.count", 1) do
-        post :create, {:ban => {:duration => 60, :reason => "xxx", :user_id => @user.id}}, {:user_id => @mod.id}
+        post_auth bans_path, @mod, params: {ban: {duration: 60, reason: "xxx", user_id: @user.id}}
       end
       ban = Ban.last
       assert_redirected_to(ban_path(ban))
     end
 
     should "update a ban" do
-      post :update, {:id => @ban.id, :ban => {:reason => "xxx", :duration => 60}}, {:user_id => @mod.id}
+      put_auth ban_path(@ban.id), @mod, params: {ban: {reason: "xxx", duration: 60}}
       @ban.reload
       assert_equal("xxx", @ban.reason)
       assert_redirected_to(ban_path(@ban))
@@ -52,7 +52,7 @@ class BansControllerTest < ActionController::TestCase
 
     should "destroy a ban" do
       assert_difference("Ban.count", -1) do
-        post :destroy, {:id => @ban.id}, {:user_id => @mod.id}
+        delete_auth ban_path(@ban.id), @mod
       end
       assert_redirected_to(bans_path)
     end