Raise error on unpermitted params.

Fail loudly if we forget to whitelist a param instead of silently
ignoring it.

misc models: convert to strong params.

artist commentaries: convert to strong params.

* Disallow changing or setting post_id to a nonexistent post.

artists: convert to strong params.

* Disallow setting `is_banned` in create/update actions. Changing it
  this way instead of with the ban/unban actions would leave the artist in
  a partially banned state.

bans: convert to strong params.

* Disallow changing the user_id after the ban has been created.

comments: convert to strong params.

favorite groups: convert to strong params.

news updates: convert to strong params.

post appeals: convert to strong params.

post flags: convert to strong params.

* Disallow users from setting the `is_deleted` / `is_resolved` flags.

ip bans: convert to strong params.

user feedbacks: convert to strong params.

* Disallow users from setting `disable_dmail_notification` when creating feedbacks.
* Disallow changing the user_id after the feedback has been created.

notes: convert to strong params.

wiki pages: convert to strong params.

* Also fix non-Builders being able to delete wiki pages.

saved searches: convert to strong params.

pools: convert to strong params.

* Disallow setting `post_count` or `is_deleted` in create/update actions.

janitor trials: convert to strong params.

post disapprovals: convert to strong params.

* Factor out quick-mod bar to shared partial.
* Fix quick-mod bar to use `Post#is_approvable?` to determine visibility
  of Approve button.

dmail filters: convert to strong params.

password resets: convert to strong params.

user name change requests: convert to strong params.

posts: convert to strong params.

users: convert to strong params.

* Disallow setting password_hash, last_logged_in_at, last_forum_read_at,
  has_mail, and dmail_filter_attributes[user_id].

* Remove initialize_default_image_size (dead code).

uploads: convert to strong params.

* Remove `initialize_status` because status already defaults to pending
  in the database.

tag aliases/implications: convert to strong params.

tags: convert to strong params.

forum posts: convert to strong params.

* Disallow changing the topic_id after creating the post.
* Disallow setting is_deleted (destroy/undelete actions should be used instead).
* Remove is_sticky / is_locked (nonexistent attributes).

forum topics: convert to strong params.

* merges https://github.com/evazion/danbooru/tree/wip-rails-5.1
* lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4)
* switch to factorybot and change all references

Co-authored-by: r888888888 <r888888888@gmail.com>
Co-authored-by: evazion <noizave@gmail.com>

add diffs

test/functional/favorite_groups_controller_test.rb

@@ -1,80 +1,75 @@
 require 'test_helper'
 
-class FavoriteGroupsControllerTest < ActionController::TestCase
+class FavoriteGroupsControllerTest < ActionDispatch::IntegrationTest
   context "The favorite groups controller" do
     setup do
-      @user = FactoryGirl.create(:user)
-      CurrentUser.user = @user
-      CurrentUser.ip_addr = "127.0.0.1"
+      @user = create(:user)
+      as_user do
+        @favgroup = create(:favorite_group)
+      end
     end
 
     context "index action" do
       should "render" do
-        get :index
+        get favorite_groups_path
         assert_response :success
       end
     end
 
     context "show action" do
       should "render" do
-        favgroup = FactoryGirl.create(:favorite_group)
-
-        get :show, { id: favgroup.id }
+        get favorite_group_path(@favgroup)
         assert_response :success
       end
     end
 
     context "new action" do
       should "render" do
-        get :new, {}, { user_id: @user.id }
+        get_auth new_favorite_group_path, @user
         assert_response :success
       end
     end
 
     context "create action" do
       should "render" do
-        post :create, { favorite_group: FactoryGirl.attributes_for(:favorite_group) }, { user_id: @user.id }
+        post_auth favorite_groups_path, @user, params: { favorite_group: FactoryBot.attributes_for(:favorite_group) }
         assert_redirected_to favorite_groups_path
       end
     end
 
     context "edit action" do
       should "render" do
-        favgroup = FactoryGirl.create(:favorite_group, creator: @user)
-
-        get :edit, { id: favgroup.id }, { user_id: @user.id }
+        get_auth edit_favorite_group_path(@favgroup), @user
         assert_response :success
       end
     end
 
     context "update action" do
       should "render" do
-        favgroup = FactoryGirl.create(:favorite_group, creator: @user)
-        params = { id: favgroup.id, favorite_group: { name: "foo" } }
-
-        put :update, params, { user_id: @user.id }
-        assert_redirected_to favgroup
-        assert_equal("foo", favgroup.reload.name)
+        params = { favorite_group: { name: "foo" } }
+        put_auth favorite_group_path(@favgroup), @user, params: params
+        assert_redirected_to @favgroup
+        assert_equal("foo", @favgroup.reload.name)
       end
     end
 
     context "destroy action" do
       should "render" do
-        favgroup = FactoryGirl.create(:favorite_group, creator: @user)
-
-        delete :destroy, { id: favgroup.id }, { user_id: @user.id }
+        delete_auth favorite_group_path(@favgroup), @user
         assert_redirected_to favorite_groups_path
       end
     end
 
     context "add_post action" do
       should "render" do
-        favgroup = FactoryGirl.create(:favorite_group, creator: @user)
-        post = FactoryGirl.create(:post)
+        as_user do
+          @post = FactoryBot.create(:post)
+        end
 
-        put :add_post, { id: favgroup.id, post_id: post.id, format: "js" }, { user_id: @user.id }
+        put_auth add_post_favorite_group_path(@favgroup), @user, params: {post_id: @post.id, format: "js"}
         assert_response :success
-        assert_equal([post.id], favgroup.reload.post_id_array)
+        @favgroup.reload
+        assert_equal([@post.id], @favgroup.post_id_array)
       end
     end
   end