Raise error on unpermitted params.

Fail loudly if we forget to whitelist a param instead of silently
ignoring it.

misc models: convert to strong params.

artist commentaries: convert to strong params.

* Disallow changing or setting post_id to a nonexistent post.

artists: convert to strong params.

* Disallow setting `is_banned` in create/update actions. Changing it
  this way instead of with the ban/unban actions would leave the artist in
  a partially banned state.

bans: convert to strong params.

* Disallow changing the user_id after the ban has been created.

comments: convert to strong params.

favorite groups: convert to strong params.

news updates: convert to strong params.

post appeals: convert to strong params.

post flags: convert to strong params.

* Disallow users from setting the `is_deleted` / `is_resolved` flags.

ip bans: convert to strong params.

user feedbacks: convert to strong params.

* Disallow users from setting `disable_dmail_notification` when creating feedbacks.
* Disallow changing the user_id after the feedback has been created.

notes: convert to strong params.

wiki pages: convert to strong params.

* Also fix non-Builders being able to delete wiki pages.

saved searches: convert to strong params.

pools: convert to strong params.

* Disallow setting `post_count` or `is_deleted` in create/update actions.

janitor trials: convert to strong params.

post disapprovals: convert to strong params.

* Factor out quick-mod bar to shared partial.
* Fix quick-mod bar to use `Post#is_approvable?` to determine visibility
  of Approve button.

dmail filters: convert to strong params.

password resets: convert to strong params.

user name change requests: convert to strong params.

posts: convert to strong params.

users: convert to strong params.

* Disallow setting password_hash, last_logged_in_at, last_forum_read_at,
  has_mail, and dmail_filter_attributes[user_id].

* Remove initialize_default_image_size (dead code).

uploads: convert to strong params.

* Remove `initialize_status` because status already defaults to pending
  in the database.

tag aliases/implications: convert to strong params.

tags: convert to strong params.

forum posts: convert to strong params.

* Disallow changing the topic_id after creating the post.
* Disallow setting is_deleted (destroy/undelete actions should be used instead).
* Remove is_sticky / is_locked (nonexistent attributes).

forum topics: convert to strong params.

* merges https://github.com/evazion/danbooru/tree/wip-rails-5.1
* lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4)
* switch to factorybot and change all references

Co-authored-by: r888888888 <r888888888@gmail.com>
Co-authored-by: evazion <noizave@gmail.com>

add diffs

test/functional/ip_bans_controller_test.rb

@@ -1,16 +1,14 @@
 require 'test_helper'
 
-class IpBansControllerTest < ActionController::TestCase
+class IpBansControllerTest < ActionDispatch::IntegrationTest
   context "The ip bans controller" do
     setup do
-      @admin = FactoryGirl.create(:admin_user)
-      CurrentUser.user = @admin
-      CurrentUser.ip_addr = "127.0.0.1"
+      @admin = create(:admin_user)
     end
 
     context "new action" do
       should "render" do
-        get :new, {}, {:user_id => @admin.id}
+        get_auth new_ip_ban_path, @admin
         assert_response :success
       end
     end
@@ -18,24 +16,26 @@ class IpBansControllerTest < ActionController::TestCase
     context "create action" do
       should "create a new ip ban" do
         assert_difference("IpBan.count", 1) do
-          post :create, {:ip_ban => {:ip_addr => "1.2.3.4", :reason => "xyz"}}, {:user_id => @admin.id}
+          post_auth ip_bans_path, @admin, params: {:ip_ban => {:ip_addr => "1.2.3.4", :reason => "xyz"}}
         end
       end
     end
 
     context "index action" do
       setup do
-        FactoryGirl.create(:ip_ban)
+        as(@admin) do
+          create(:ip_ban)
+        end
       end
 
       should "render" do
-        get :index, {}, {:user_id => @admin.id}
+        get_auth ip_bans_path, @admin
         assert_response :success
       end
 
       context "with search parameters" do
         should "render" do
-          get :index, {:search => {:ip_addr => "1.2.3.4"}}, {:user_id => @admin.id}
+          get_auth ip_bans_path, @admin, params: {:search => {:ip_addr => "1.2.3.4"}}
           assert_response :success
         end
       end
@@ -43,12 +43,14 @@ class IpBansControllerTest < ActionController::TestCase
 
     context "destroy action" do
       setup do
-        @ip_ban = FactoryGirl.create(:ip_ban)
+        as(@admin) do
+          @ip_ban = create(:ip_ban)
+        end
       end
 
       should "destroy an ip ban" do
         assert_difference("IpBan.count", -1) do
-          post :destroy, {:id => @ip_ban.id, :format => "js"}, {:user_id => @admin.id}
+          delete_auth ip_ban_path(@ip_ban), @admin, params: {:format => "js"}
         end
       end
     end