Raise error on unpermitted params.

Fail loudly if we forget to whitelist a param instead of silently
ignoring it.

misc models: convert to strong params.

artist commentaries: convert to strong params.

* Disallow changing or setting post_id to a nonexistent post.

artists: convert to strong params.

* Disallow setting `is_banned` in create/update actions. Changing it
  this way instead of with the ban/unban actions would leave the artist in
  a partially banned state.

bans: convert to strong params.

* Disallow changing the user_id after the ban has been created.

comments: convert to strong params.

favorite groups: convert to strong params.

news updates: convert to strong params.

post appeals: convert to strong params.

post flags: convert to strong params.

* Disallow users from setting the `is_deleted` / `is_resolved` flags.

ip bans: convert to strong params.

user feedbacks: convert to strong params.

* Disallow users from setting `disable_dmail_notification` when creating feedbacks.
* Disallow changing the user_id after the feedback has been created.

notes: convert to strong params.

wiki pages: convert to strong params.

* Also fix non-Builders being able to delete wiki pages.

saved searches: convert to strong params.

pools: convert to strong params.

* Disallow setting `post_count` or `is_deleted` in create/update actions.

janitor trials: convert to strong params.

post disapprovals: convert to strong params.

* Factor out quick-mod bar to shared partial.
* Fix quick-mod bar to use `Post#is_approvable?` to determine visibility
  of Approve button.

dmail filters: convert to strong params.

password resets: convert to strong params.

user name change requests: convert to strong params.

posts: convert to strong params.

users: convert to strong params.

* Disallow setting password_hash, last_logged_in_at, last_forum_read_at,
  has_mail, and dmail_filter_attributes[user_id].

* Remove initialize_default_image_size (dead code).

uploads: convert to strong params.

* Remove `initialize_status` because status already defaults to pending
  in the database.

tag aliases/implications: convert to strong params.

tags: convert to strong params.

forum posts: convert to strong params.

* Disallow changing the topic_id after creating the post.
* Disallow setting is_deleted (destroy/undelete actions should be used instead).
* Remove is_sticky / is_locked (nonexistent attributes).

forum topics: convert to strong params.

* merges https://github.com/evazion/danbooru/tree/wip-rails-5.1
* lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4)
* switch to factorybot and change all references

Co-authored-by: r888888888 <r888888888@gmail.com>
Co-authored-by: evazion <noizave@gmail.com>

add diffs

test/functional/moderator/dashboards_controller_test.rb

@@ -1,130 +1,141 @@
 require 'test_helper'
 
 module Moderator
-  class DashboardsControllerTest < ActionController::TestCase
+  class DashboardsControllerTest < ActionDispatch::IntegrationTest
     context "The moderator dashboards controller" do
       setup do
-        @admin = FactoryGirl.create(:admin_user)
-        CurrentUser.user = @admin
-        CurrentUser.ip_addr = "127.0.0.1"
+        travel_to(1.month.ago) do
+          @user = create(:gold_user)
+        end
+        @admin = create(:admin_user)
         Danbooru.config.stubs(:member_comment_time_threshold).returns(1.week.from_now)
       end
 
       context "show action" do
         context "for mod actions" do
           setup do
-            @mod_action = FactoryGirl.create(:mod_action)
+            as(@admin) do
+              @mod_action = create(:mod_action)
+            end
           end
 
           should "render" do
-            assert_equal(1, ModAction.count)
-            get :show, {}, {:user_id => @admin.id}
+            get_auth moderator_dashboard_path, @admin
             assert_response :success
           end
         end
 
         context "for user feedbacks" do
           setup do
-            @feedback = FactoryGirl.create(:user_feedback)
+            as(@user) do
+              @feedback = create(:user_feedback)
+            end
           end
 
           should "render" do
-            assert_equal(1, UserFeedback.count)
-            get :show, {}, {:user_id => @admin.id}
+            get_auth moderator_dashboard_path, @admin
             assert_response :success
           end
         end
 
         context "for wiki pages" do
           setup do
-            @wiki_page = FactoryGirl.create(:wiki_page)
+            as(@user) do
+              @wiki_page = create(:wiki_page)
+            end
           end
 
           should "render" do
-            assert_equal(1, WikiPageVersion.count)
-            get :show, {}, {:user_id => @admin.id}
+            get_auth moderator_dashboard_path, @admin
             assert_response :success
           end
         end
 
         context "for tags and uploads" do
           setup do
-            @post = FactoryGirl.create(:post)
+            as(@user) do
+              @post = create(:post)
+            end
           end
 
           should "render" do
-            assert_equal(1, PostArchive.count)
-            get :show, {}, {:user_id => @admin.id}
+            get_auth moderator_dashboard_path, @admin
             assert_response :success
           end
         end
 
         context "for notes"do
           setup do
-            @post = FactoryGirl.create(:post)
-            @note = FactoryGirl.create(:note, :post_id => @post.id)
+            as(@user) do
+              @post = create(:post)
+              @note = create(:note, :post_id => @post.id)
+            end
           end
 
           should "render" do
-            assert_equal(1, NoteVersion.count)
-            get :show, {}, {:user_id => @admin.id}
+            get_auth moderator_dashboard_path, @admin
             assert_response :success
           end
         end
 
         context "for comments" do
           setup do
-            @users = (0..5).map {FactoryGirl.create(:user)}
+            @users = (0..5).map {create(:user)}
 
-            CurrentUser.scoped(@users[0], "1.2.3.4") do
-              @comment = FactoryGirl.create(:comment)
+            CurrentUser.as(@users[0]) do
+              @comment = create(:comment)
             end
 
             @users.each do |user|
-              CurrentUser.scoped(user, "1.2.3.4") do
+              CurrentUser.as(user) do
                 @comment.vote!(-1)
               end
             end
           end
 
           should "render" do
-            get :show, {}, {:user_id => @admin.id}
+            get_auth moderator_dashboard_path, @admin
             assert_response :success
           end
         end
 
         context "for artists" do
           setup do
-            @artist = FactoryGirl.create(:artist)
+            as(@user) do
+              @artist = create(:artist)
+            end
           end
 
           should "render" do
-            get :show, {}, {:user_id => @admin.id}
-            assert_equal(1, ArtistVersion.count)
+            get_auth moderator_dashboard_path, @admin
             assert_response :success
           end
         end
 
         context "for flags" do
           setup do
-            @post = FactoryGirl.create(:post)
-            @post.flag!("blah")
+            as(@user) do
+              @post = create(:post)
+              @post.flag!("blah")
+            end
           end
 
           should "render" do
-            get :show, {}, {:user_id => @admin.id}
+            get_auth moderator_dashboard_path, @admin
             assert_response :success
           end
         end
 
         context "for appeals" do
           setup do
-            @post = FactoryGirl.create(:post, :is_deleted => true)
-            @post.appeal!("blah")
+            as(@user) do
+              @post = create(:post, :is_deleted => true)
+              @post.appeal!("blah")
+            end
           end
 
           should "render" do
-            get :show, {}, {:user_id => @admin.id}
+            get_auth moderator_dashboard_path, @admin
             assert_response :success
           end
         end