Raise error on unpermitted params.

Fail loudly if we forget to whitelist a param instead of silently
ignoring it.

misc models: convert to strong params.

artist commentaries: convert to strong params.

* Disallow changing or setting post_id to a nonexistent post.

artists: convert to strong params.

* Disallow setting `is_banned` in create/update actions. Changing it
  this way instead of with the ban/unban actions would leave the artist in
  a partially banned state.

bans: convert to strong params.

* Disallow changing the user_id after the ban has been created.

comments: convert to strong params.

favorite groups: convert to strong params.

news updates: convert to strong params.

post appeals: convert to strong params.

post flags: convert to strong params.

* Disallow users from setting the `is_deleted` / `is_resolved` flags.

ip bans: convert to strong params.

user feedbacks: convert to strong params.

* Disallow users from setting `disable_dmail_notification` when creating feedbacks.
* Disallow changing the user_id after the feedback has been created.

notes: convert to strong params.

wiki pages: convert to strong params.

* Also fix non-Builders being able to delete wiki pages.

saved searches: convert to strong params.

pools: convert to strong params.

* Disallow setting `post_count` or `is_deleted` in create/update actions.

janitor trials: convert to strong params.

post disapprovals: convert to strong params.

* Factor out quick-mod bar to shared partial.
* Fix quick-mod bar to use `Post#is_approvable?` to determine visibility
  of Approve button.

dmail filters: convert to strong params.

password resets: convert to strong params.

user name change requests: convert to strong params.

posts: convert to strong params.

users: convert to strong params.

* Disallow setting password_hash, last_logged_in_at, last_forum_read_at,
  has_mail, and dmail_filter_attributes[user_id].

* Remove initialize_default_image_size (dead code).

uploads: convert to strong params.

* Remove `initialize_status` because status already defaults to pending
  in the database.

tag aliases/implications: convert to strong params.

tags: convert to strong params.

forum posts: convert to strong params.

* Disallow changing the topic_id after creating the post.
* Disallow setting is_deleted (destroy/undelete actions should be used instead).
* Remove is_sticky / is_locked (nonexistent attributes).

forum topics: convert to strong params.

* merges https://github.com/evazion/danbooru/tree/wip-rails-5.1
* lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4)
* switch to factorybot and change all references

Co-authored-by: r888888888 <r888888888@gmail.com>
Co-authored-by: evazion <noizave@gmail.com>

add diffs

test/functional/notes_controller_test.rb

@@ -1,21 +1,17 @@
 require 'test_helper'
 
-class NotesControllerTest < ActionController::TestCase
+class NotesControllerTest < ActionDispatch::IntegrationTest
   context "The notes controller" do
     setup do
-      @user = FactoryGirl.create(:user)
-      CurrentUser.user = @user
-      CurrentUser.ip_addr = "127.0.0.1"
-      @note = FactoryGirl.create(:note, body: "000")
-    end
-
-    teardown do
-      CurrentUser.user = nil
+      @user = create(:user)
+      as_user do
+        @note = create(:note, body: "000")
+      end
     end
 
     context "index action" do
       should "list all notes" do
-        get :index
+        get notes_path
         assert_response :success
       end
 
@@ -32,14 +28,14 @@ class NotesControllerTest < ActionController::TestCase
           }
         }
 
-        get :index, params
+        get notes_path, params: params
         assert_response :success
       end
     end
 
     context "show action" do
       should "render" do
-        get :show, { id: @note.id, format: "json" }
+        get note_path(@note), params: { format: "json" }
         assert_response :success
       end
     end
@@ -47,53 +43,58 @@ class NotesControllerTest < ActionController::TestCase
     context "create action" do
       should "create a note" do
         assert_difference("Note.count", 1) do
-          @post = FactoryGirl.create(:post)
-          post :create, {:note => {:x => 0, :y => 0, :width => 10, :height => 10, :body => "abc", :post_id => @post.id}, :format => :json}, {:user_id => @user.id}
+          as_user do
+            @post = create(:post)
+          end
+          post_auth notes_path, @user, params: {:note => {:x => 0, :y => 0, :width => 10, :height => 10, :body => "abc", :post_id => @post.id}, :format => :json}
         end
       end
     end
 
     context "update action" do
       should "update a note" do
-        post :update, {:id => @note.id, :note => {:body => "xyz"}}, {:user_id => @user.id}
+        put_auth note_path(@note), @user, params: {:note => {:body => "xyz"}}
         assert_equal("xyz", @note.reload.body)
       end
 
       should "not allow changing the post id to another post" do
-        @other = FactoryGirl.create(:post)
-        post :update, {:format => "json", :id => @note.id, :note => {:post_id => @other.id}}, {:user_id => @user.id}
-
+        as(@admin) do
+          @other = create(:post)
+        end
+        put_auth note_path(@note), @user, params: {:format => "json", :id => @note.id, :note => {:post_id => @other.id}}
         assert_not_equal(@other.id, @note.reload.post_id)
       end
     end
 
     context "destroy action" do
       should "destroy a note" do
-        post :destroy, {:id => @note.id}, {:user_id => @user.id}
+        delete_auth note_path(@note), @user
         assert_equal(false, @note.reload.is_active?)
       end
     end
 
     context "revert action" do
       setup do
-        Timecop.travel(1.day.from_now) do
-          @note.update_attributes(:body => "111")
-        end
-        Timecop.travel(2.days.from_now) do
-          @note.update_attributes(:body => "222")
+        as_user do
+          travel_to(1.day.from_now) do
+            @note.update(:body => "111")
+          end
+          travel_to(2.days.from_now) do
+            @note.update(:body => "222")
+          end
         end
       end
 
       should "revert to a previous version" do
-        post :revert, {:id => @note.id, :version_id => @note.versions(true).first.id}, {:user_id => @user.id}
+        put_auth revert_note_path(@note), @user, params: {:version_id => @note.versions.first.id}
         assert_equal("000", @note.reload.body)
       end
 
       should "not allow reverting to a previous version of another note" do
-        @note2 = FactoryGirl.create(:note, :body => "note 2")
-
-        post :revert, { :id => @note.id, :version_id => @note2.versions(true).first.id }, {:user_id => @user.id}
-
+        as_user do
+          @note2 = create(:note, :body => "note 2")
+        end
+        put_auth revert_note_path(@note), @user, params: { :version_id => @note2.versions.first.id }
         assert_not_equal(@note.reload.body, @note2.body)
         assert_response :missing
       end