Raise error on unpermitted params.

Fail loudly if we forget to whitelist a param instead of silently
ignoring it.

misc models: convert to strong params.

artist commentaries: convert to strong params.

* Disallow changing or setting post_id to a nonexistent post.

artists: convert to strong params.

* Disallow setting `is_banned` in create/update actions. Changing it
  this way instead of with the ban/unban actions would leave the artist in
  a partially banned state.

bans: convert to strong params.

* Disallow changing the user_id after the ban has been created.

comments: convert to strong params.

favorite groups: convert to strong params.

news updates: convert to strong params.

post appeals: convert to strong params.

post flags: convert to strong params.

* Disallow users from setting the `is_deleted` / `is_resolved` flags.

ip bans: convert to strong params.

user feedbacks: convert to strong params.

* Disallow users from setting `disable_dmail_notification` when creating feedbacks.
* Disallow changing the user_id after the feedback has been created.

notes: convert to strong params.

wiki pages: convert to strong params.

* Also fix non-Builders being able to delete wiki pages.

saved searches: convert to strong params.

pools: convert to strong params.

* Disallow setting `post_count` or `is_deleted` in create/update actions.

janitor trials: convert to strong params.

post disapprovals: convert to strong params.

* Factor out quick-mod bar to shared partial.
* Fix quick-mod bar to use `Post#is_approvable?` to determine visibility
  of Approve button.

dmail filters: convert to strong params.

password resets: convert to strong params.

user name change requests: convert to strong params.

posts: convert to strong params.

users: convert to strong params.

* Disallow setting password_hash, last_logged_in_at, last_forum_read_at,
  has_mail, and dmail_filter_attributes[user_id].

* Remove initialize_default_image_size (dead code).

uploads: convert to strong params.

* Remove `initialize_status` because status already defaults to pending
  in the database.

tag aliases/implications: convert to strong params.

tags: convert to strong params.

forum posts: convert to strong params.

* Disallow changing the topic_id after creating the post.
* Disallow setting is_deleted (destroy/undelete actions should be used instead).
* Remove is_sticky / is_locked (nonexistent attributes).

forum topics: convert to strong params.

* merges https://github.com/evazion/danbooru/tree/wip-rails-5.1
* lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4)
* switch to factorybot and change all references

Co-authored-by: r888888888 <r888888888@gmail.com>
Co-authored-by: evazion <noizave@gmail.com>

add diffs

test/functional/post_flags_controller_test.rb

@@ -1,41 +1,36 @@
 require 'test_helper'
 
-class PostFlagsControllerTest < ActionController::TestCase
+class PostFlagsControllerTest < ActionDispatch::IntegrationTest
   context "The post flags controller" do
     setup do
-      Timecop.travel(2.weeks.ago) do
-        @user = FactoryGirl.create(:user)
+      travel_to(2.weeks.ago) do
+        @user = create(:user)
       end
-      CurrentUser.user = @user
-      CurrentUser.ip_addr = "127.0.0.1"
-    end
-
-    teardown do
-      CurrentUser.user = nil
-      CurrentUser.ip_addr = nil
     end
 
     context "new action" do
       should "render" do
-        get :new, {}, {:user_id => @user.id}
+        get_auth new_post_flag_path, @user
         assert_response :success
       end
     end
 
     context "index action" do
       setup do
-        @post = FactoryGirl.create(:post)
-        @post_flag = FactoryGirl.create(:post_flag, :post => @post)
+        @user.as_current do
+          @post = create(:post)
+          @post_flag = create(:post_flag, :post => @post)
+        end
       end
 
       should "render" do
-        get :index, {}, {:user_id => @user.id}
+        get_auth post_flags_path, @user
         assert_response :success
       end
 
       context "with search parameters" do
         should "render" do
-          get :index, {:search => {:post_id => @post_flag.post_id}}, {:user_id => @user.id}
+          get_auth post_flags_path, @user, params: {:search => {:post_id => @post_flag.post_id}}
           assert_response :success
         end
       end
@@ -43,14 +38,16 @@ class PostFlagsControllerTest < ActionController::TestCase
 
     context "create action" do
       setup do
-        @post = FactoryGirl.create(:post)
+        @user.as_current do
+          @post = create(:post)
+        end
       end
 
       should "create a new flag" do
         assert_difference("PostFlag.count", 1) do
-          post :create, {:format => "js", :post_flag => {:post_id => @post.id, :reason => "xxx"}}, {:user_id => @user.id}
-          assert_not_nil(assigns(:post_flag))
-          assert_equal([], assigns(:post_flag).errors.full_messages)
+          assert_difference("PostFlag.count") do
+            post_auth post_flags_path, @user, params: {:format => "js", :post_flag => {:post_id => @post.id, :reason => "xxx"}}
+          end
         end
       end
     end