Raise error on unpermitted params.

Fail loudly if we forget to whitelist a param instead of silently
ignoring it.

misc models: convert to strong params.

artist commentaries: convert to strong params.

* Disallow changing or setting post_id to a nonexistent post.

artists: convert to strong params.

* Disallow setting `is_banned` in create/update actions. Changing it
  this way instead of with the ban/unban actions would leave the artist in
  a partially banned state.

bans: convert to strong params.

* Disallow changing the user_id after the ban has been created.

comments: convert to strong params.

favorite groups: convert to strong params.

news updates: convert to strong params.

post appeals: convert to strong params.

post flags: convert to strong params.

* Disallow users from setting the `is_deleted` / `is_resolved` flags.

ip bans: convert to strong params.

user feedbacks: convert to strong params.

* Disallow users from setting `disable_dmail_notification` when creating feedbacks.
* Disallow changing the user_id after the feedback has been created.

notes: convert to strong params.

wiki pages: convert to strong params.

* Also fix non-Builders being able to delete wiki pages.

saved searches: convert to strong params.

pools: convert to strong params.

* Disallow setting `post_count` or `is_deleted` in create/update actions.

janitor trials: convert to strong params.

post disapprovals: convert to strong params.

* Factor out quick-mod bar to shared partial.
* Fix quick-mod bar to use `Post#is_approvable?` to determine visibility
  of Approve button.

dmail filters: convert to strong params.

password resets: convert to strong params.

user name change requests: convert to strong params.

posts: convert to strong params.

users: convert to strong params.

* Disallow setting password_hash, last_logged_in_at, last_forum_read_at,
  has_mail, and dmail_filter_attributes[user_id].

* Remove initialize_default_image_size (dead code).

uploads: convert to strong params.

* Remove `initialize_status` because status already defaults to pending
  in the database.

tag aliases/implications: convert to strong params.

tags: convert to strong params.

forum posts: convert to strong params.

* Disallow changing the topic_id after creating the post.
* Disallow setting is_deleted (destroy/undelete actions should be used instead).
* Remove is_sticky / is_locked (nonexistent attributes).

forum topics: convert to strong params.

* merges https://github.com/evazion/danbooru/tree/wip-rails-5.1
* lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4)
* switch to factorybot and change all references

Co-authored-by: r888888888 <r888888888@gmail.com>
Co-authored-by: evazion <noizave@gmail.com>

add diffs

test/functional/post_votes_controller_test.rb

@@ -1,71 +1,52 @@
 require 'test_helper'
 
-class PostVotesControllerTest < ActionController::TestCase
+class PostVotesControllerTest < ActionDispatch::IntegrationTest
   context "The post vote controller" do
     setup do
-      @user = FactoryGirl.create(:gold_user)
-      CurrentUser.user = @user
-      CurrentUser.ip_addr = "127.0.0.1"
-      @post = FactoryGirl.create(:post)
-    end
-
-    teardown do
-      CurrentUser.user = nil
-      CurrentUser.ip_addr = nil
+      @user = create(:gold_user)
+      @user.as_current do
+        @post = create(:post)
+      end
     end
 
     context "create action" do
       should "not allow anonymous users to vote" do
-        p1 = FactoryGirl.create(:post)
-        post :create, {:post_id => p1.id, :score => "up", :format => "js"}
-
+        post post_votes_path(post_id: @post.id), params: {:score => "up", :format => "js"}
         assert_response 403
-        assert_equal(0, p1.reload.score)
+        assert_equal(0, @post.reload.score)
       end
 
       should "not allow banned users to vote" do
-        CurrentUser.scoped(FactoryGirl.create(:banned_user)) do
-          p1 = FactoryGirl.create(:post)
-          post :create, {:post_id => p1.id, :score => "up", :format => "js"}, {:user_id => CurrentUser.id}
-
-          assert_response 403
-          assert_equal(0, p1.reload.score)
-        end
+        @banned = create(:banned_user)
+        post_auth post_votes_path(post_id: @post.id), @banned, params: {:score => "up", :format => "js"}
+        assert_response 403
+        assert_equal(0, @post.reload.score)
       end
 
       should "not allow members to vote" do
-        CurrentUser.scoped(FactoryGirl.create(:member_user)) do
-          p1 = FactoryGirl.create(:post)
-          post :create, {:post_id => p1.id, :score => "up", :format => "js"}, {:user_id => CurrentUser.id}
-
-          assert_response 403
-          assert_equal(0, p1.reload.score)
-        end
+        @member = create(:member_user)
+        post_auth post_votes_path(post_id: @post.id), @member, params: {:score => "up", :format => "js"}
+        assert_response 403
+        assert_equal(0, @post.reload.score)
       end
 
       should "increment a post's score if the score is positive" do
-        post :create, {:post_id => @post.id, :score => "up", :format => "js"}, {:user_id => @user.id}
+        post_auth post_votes_path(post_id: @post.id), @user, params: {:score => "up", :format => "js"}
         assert_response :success
         @post.reload
         assert_equal(1, @post.score)
       end
 
-      context "that fails" do
-        should "return a 500" do
-          post :create, {:post_id => @post.id, :score => "up", :format => "json"}, {:user_id => @user.id}
-          post :create, {:post_id => @post.id, :score => "up", :format => "json"}, {:user_id => @user.id}
-          assert_equal("{\"success\": false, \"reason\": \"You have already voted for this post\"}", response.body.strip)
-        end
-      end
-
       context "for a post that has already been voted on" do
         setup do
-          @post.vote!("up")
+          @user.as_current do
+            @post.vote!("up")
+          end
         end
 
         should "fail silently on an error" do
           assert_nothing_raised do
-            post :create, {:post_id => @post.id, :score => "up", :format => "js"}, {:user_id => @user.id}
+            post_auth post_votes_path(post_id: @post.id), @user, params: {:score => "up", :format => "js"}
           end
         end
       end