Raise error on unpermitted params.

Fail loudly if we forget to whitelist a param instead of silently
ignoring it.

misc models: convert to strong params.

artist commentaries: convert to strong params.

* Disallow changing or setting post_id to a nonexistent post.

artists: convert to strong params.

* Disallow setting `is_banned` in create/update actions. Changing it
  this way instead of with the ban/unban actions would leave the artist in
  a partially banned state.

bans: convert to strong params.

* Disallow changing the user_id after the ban has been created.

comments: convert to strong params.

favorite groups: convert to strong params.

news updates: convert to strong params.

post appeals: convert to strong params.

post flags: convert to strong params.

* Disallow users from setting the `is_deleted` / `is_resolved` flags.

ip bans: convert to strong params.

user feedbacks: convert to strong params.

* Disallow users from setting `disable_dmail_notification` when creating feedbacks.
* Disallow changing the user_id after the feedback has been created.

notes: convert to strong params.

wiki pages: convert to strong params.

* Also fix non-Builders being able to delete wiki pages.

saved searches: convert to strong params.

pools: convert to strong params.

* Disallow setting `post_count` or `is_deleted` in create/update actions.

janitor trials: convert to strong params.

post disapprovals: convert to strong params.

* Factor out quick-mod bar to shared partial.
* Fix quick-mod bar to use `Post#is_approvable?` to determine visibility
  of Approve button.

dmail filters: convert to strong params.

password resets: convert to strong params.

user name change requests: convert to strong params.

posts: convert to strong params.

users: convert to strong params.

* Disallow setting password_hash, last_logged_in_at, last_forum_read_at,
  has_mail, and dmail_filter_attributes[user_id].

* Remove initialize_default_image_size (dead code).

uploads: convert to strong params.

* Remove `initialize_status` because status already defaults to pending
  in the database.

tag aliases/implications: convert to strong params.

tags: convert to strong params.

forum posts: convert to strong params.

* Disallow changing the topic_id after creating the post.
* Disallow setting is_deleted (destroy/undelete actions should be used instead).
* Remove is_sticky / is_locked (nonexistent attributes).

forum topics: convert to strong params.

* merges https://github.com/evazion/danbooru/tree/wip-rails-5.1
* lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4)
* switch to factorybot and change all references

Co-authored-by: r888888888 <r888888888@gmail.com>
Co-authored-by: evazion <noizave@gmail.com>

add diffs

test/functional/saved_searches_controller_test.rb

@@ -1,55 +1,65 @@
 require 'test_helper'
 
-class SavedSearchesControllerTest < ActionController::TestCase
+class SavedSearchesControllerTest < ActionDispatch::IntegrationTest
   context "The saved searches controller" do
     setup do
-      @user = FactoryGirl.create(:user)
-      CurrentUser.user = @user
-      CurrentUser.ip_addr = "127.0.0.1"
+      @user = create(:user)
+      as_user do
+        @saved_search = create(:saved_search, user: @user)
+      end
       mock_saved_search_service!
     end
 
     context "index action" do
       should "render" do
-        get :index, {}, { user_id: @user.id }
+        get_auth saved_searches_path, @user
         assert_response :success
+        assert_select "#saved-search-#{@saved_search.id}"
       end
     end
 
     context "create action" do
       should "render" do
-        params = { saved_search_tags: "bkub", saved_search_labels: "artist" }
-
-        post :create, params, { user_id: @user.id }
+        post_auth saved_searches_path, @user, params: { saved_search: { query: "bkub", label_string: "artist" }}
         assert_response :redirect
       end
+
+      should "disable labels when the disable_labels param is given" do
+        post_auth saved_searches_path, @user, params: { saved_search: { query: "bkub", disable_labels: "1" }}
+        assert_equal(true, @user.reload.disable_categorized_saved_searches)
+      end
     end
 
     context "edit action" do
       should "render" do
-        saved_search = FactoryGirl.create(:saved_search, user: @user)
+        as_user do
+          @saved_search = create(:saved_search, user: @user)
+        end
 
-        get :edit, { id: saved_search.id }, { user_id: @user.id }
+        get_auth edit_saved_search_path(@saved_search), @user, params: { id: @saved_search.id }
         assert_response :success
       end
     end
 
     context "update action" do
       should "render" do
-        saved_search = FactoryGirl.create(:saved_search, user: @user)
-        params = { id: saved_search.id, saved_search: { label_string: "foo" } }
-
-        put :update, params, { user_id: @user.id }
+        as_user do
+          @saved_search = create(:saved_search, user: @user)
+        end
+        params = { id: @saved_search.id, saved_search: { label_string: "foo" } }
+        put_auth saved_search_path(@saved_search), @user, params: params
         assert_redirected_to saved_searches_path
-        assert_equal(["foo"], saved_search.reload.labels)
+        assert_equal(["foo"], @saved_search.reload.labels)
       end
     end
 
     context "destroy action" do
       should "render" do
-        saved_search = FactoryGirl.create(:saved_search, user: @user)
+        as_user do
+          @saved_search = create(:saved_search, user: @user)
+        end
 
-        delete :destroy, { id: saved_search.id }, { user_id: @user.id }
+        delete_auth saved_search_path(@saved_search), @user
         assert_redirected_to saved_searches_path
       end
     end