Raise error on unpermitted params.

Fail loudly if we forget to whitelist a param instead of silently
ignoring it.

misc models: convert to strong params.

artist commentaries: convert to strong params.

* Disallow changing or setting post_id to a nonexistent post.

artists: convert to strong params.

* Disallow setting `is_banned` in create/update actions. Changing it
  this way instead of with the ban/unban actions would leave the artist in
  a partially banned state.

bans: convert to strong params.

* Disallow changing the user_id after the ban has been created.

comments: convert to strong params.

favorite groups: convert to strong params.

news updates: convert to strong params.

post appeals: convert to strong params.

post flags: convert to strong params.

* Disallow users from setting the `is_deleted` / `is_resolved` flags.

ip bans: convert to strong params.

user feedbacks: convert to strong params.

* Disallow users from setting `disable_dmail_notification` when creating feedbacks.
* Disallow changing the user_id after the feedback has been created.

notes: convert to strong params.

wiki pages: convert to strong params.

* Also fix non-Builders being able to delete wiki pages.

saved searches: convert to strong params.

pools: convert to strong params.

* Disallow setting `post_count` or `is_deleted` in create/update actions.

janitor trials: convert to strong params.

post disapprovals: convert to strong params.

* Factor out quick-mod bar to shared partial.
* Fix quick-mod bar to use `Post#is_approvable?` to determine visibility
  of Approve button.

dmail filters: convert to strong params.

password resets: convert to strong params.

user name change requests: convert to strong params.

posts: convert to strong params.

users: convert to strong params.

* Disallow setting password_hash, last_logged_in_at, last_forum_read_at,
  has_mail, and dmail_filter_attributes[user_id].

* Remove initialize_default_image_size (dead code).

uploads: convert to strong params.

* Remove `initialize_status` because status already defaults to pending
  in the database.

tag aliases/implications: convert to strong params.

tags: convert to strong params.

forum posts: convert to strong params.

* Disallow changing the topic_id after creating the post.
* Disallow setting is_deleted (destroy/undelete actions should be used instead).
* Remove is_sticky / is_locked (nonexistent attributes).

forum topics: convert to strong params.

* merges https://github.com/evazion/danbooru/tree/wip-rails-5.1
* lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4)
* switch to factorybot and change all references

Co-authored-by: r888888888 <r888888888@gmail.com>
Co-authored-by: evazion <noizave@gmail.com>

add diffs

test/functional/sessions_controller_test.rb

@@ -1,56 +1,31 @@
 require 'test_helper'
 
-class SessionsControllerTest < ActionController::TestCase
+class SessionsControllerTest < ActionDispatch::IntegrationTest
   context "the sessions controller" do
     setup do
-      @user = FactoryGirl.create(:user)
+      @user = create(:user)
     end
 
     context "new action" do
       should "render" do
-        get :new
+        get new_session_path
         assert_response :success
       end
     end
 
     context "create action" do
       should "create a new session" do
-        post :create, {:name => @user.name, :password => "password"}
+        post session_path, params: {:name => @user.name, :password => "password"}
         assert_redirected_to posts_path
         @user.reload
         assert_equal(@user.id, session[:user_id])
         assert_not_nil(@user.last_ip_addr)
       end
-
-      should "unban user if user has expired ban" do
-        CurrentUser.scoped(@user, "127.0.0.1") do
-          @banned = FactoryGirl.create(:banned_user, ban_duration: 3)
-        end
-
-        travel_to(4.days.from_now) do
-          post :create, {name: @banned.name, password: "password"}
-          SessionLoader.new(session, {}, request, {}).load
-
-          assert_equal(@banned.id, session[:user_id])
-          assert_equal(true, @banned.ban_expired?)
-          assert_equal(false, @banned.reload.is_banned)
-        end
-      end
     end
 
     context "destroy action" do
-      setup do
-        CurrentUser.user = @user
-        CurrentUser.ip_addr = "127.0.0.1"
-      end
-
-      teardown do
-        CurrentUser.user = nil
-        CurrentUser.ip_addr = nil
-      end
-
       should "clear the session" do
-        post :destroy, {}, {:user_id => @user.id}
+        delete_auth session_path, @user
         assert_redirected_to posts_path
         assert_nil(session[:user_id])
       end