Raise error on unpermitted params.

Fail loudly if we forget to whitelist a param instead of silently
ignoring it.

misc models: convert to strong params.

artist commentaries: convert to strong params.

* Disallow changing or setting post_id to a nonexistent post.

artists: convert to strong params.

* Disallow setting `is_banned` in create/update actions. Changing it
  this way instead of with the ban/unban actions would leave the artist in
  a partially banned state.

bans: convert to strong params.

* Disallow changing the user_id after the ban has been created.

comments: convert to strong params.

favorite groups: convert to strong params.

news updates: convert to strong params.

post appeals: convert to strong params.

post flags: convert to strong params.

* Disallow users from setting the `is_deleted` / `is_resolved` flags.

ip bans: convert to strong params.

user feedbacks: convert to strong params.

* Disallow users from setting `disable_dmail_notification` when creating feedbacks.
* Disallow changing the user_id after the feedback has been created.

notes: convert to strong params.

wiki pages: convert to strong params.

* Also fix non-Builders being able to delete wiki pages.

saved searches: convert to strong params.

pools: convert to strong params.

* Disallow setting `post_count` or `is_deleted` in create/update actions.

janitor trials: convert to strong params.

post disapprovals: convert to strong params.

* Factor out quick-mod bar to shared partial.
* Fix quick-mod bar to use `Post#is_approvable?` to determine visibility
  of Approve button.

dmail filters: convert to strong params.

password resets: convert to strong params.

user name change requests: convert to strong params.

posts: convert to strong params.

users: convert to strong params.

* Disallow setting password_hash, last_logged_in_at, last_forum_read_at,
  has_mail, and dmail_filter_attributes[user_id].

* Remove initialize_default_image_size (dead code).

uploads: convert to strong params.

* Remove `initialize_status` because status already defaults to pending
  in the database.

tag aliases/implications: convert to strong params.

tags: convert to strong params.

forum posts: convert to strong params.

* Disallow changing the topic_id after creating the post.
* Disallow setting is_deleted (destroy/undelete actions should be used instead).
* Remove is_sticky / is_locked (nonexistent attributes).

forum topics: convert to strong params.

* merges https://github.com/evazion/danbooru/tree/wip-rails-5.1
* lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4)
* switch to factorybot and change all references

Co-authored-by: r888888888 <r888888888@gmail.com>
Co-authored-by: evazion <noizave@gmail.com>

add diffs

test/functional/user_feedbacks_controller_test.rb

@@ -1,51 +1,48 @@
 require 'test_helper'
 
-class UserFeedbacksControllerTest < ActionController::TestCase
+class UserFeedbacksControllerTest < ActionDispatch::IntegrationTest
   context "The user feedbacks controller" do
     setup do
-      @user = FactoryGirl.create(:user)
-      @critic = FactoryGirl.create(:gold_user)
-      @mod = FactoryGirl.create(:moderator_user)
-      CurrentUser.user = @critic
-      CurrentUser.ip_addr = "127.0.0.1"
-    end
-
-    teardown do
-      CurrentUser.user = nil
-      CurrentUser.ip_addr = nil
+      @user = create(:user)
+      @critic = create(:gold_user)
+      @mod = create(:moderator_user)
     end
 
     context "new action" do
       should "render" do
-        get :new, {}, {:user_id => @critic.id}
+        get_auth new_user_feedback_path, @critic, params: { user_feedback: { user_id: @user.id } }
         assert_response :success
       end
     end
 
     context "edit action" do
       setup do
-        @user_feedback = FactoryGirl.create(:user_feedback)
+        as(@critic) do
+          @user_feedback = create(:user_feedback, user: @user)
+        end
       end
 
       should "render" do
-        get :edit, {:id => @user_feedback.id}, {:user_id => @critic.id}
+        get_auth edit_user_feedback_path(@user_feedback), @critic
         assert_response :success
       end
     end
 
     context "index action" do
       setup do
-        @user_feedback = FactoryGirl.create(:user_feedback)
+        as(@critic) do
+          @user_feedback = create(:user_feedback, user: @user)
+        end
       end
 
       should "render" do
-        get :index, {}, {:user_id => @user.id}
+        get_auth user_feedbacks_path, @user
         assert_response :success
       end
 
       context "with search parameters" do
         should "render" do
-          get :index, {:search => {:user_id => @user.id}}, {:user_id => @critic.id}
+          get_auth user_feedbacks_path, @critic, params: {:search => {:user_id => @user.id}}
           assert_response :success
         end
       end
@@ -54,35 +51,50 @@ class UserFeedbacksControllerTest < ActionController::TestCase
     context "create action" do
       should "create a new feedback" do
         assert_difference("UserFeedback.count", 1) do
-          post :create, {:user_feedback => {:category => "positive", :user_name => @user.name, :body => "xxx"}}, {:user_id => @critic.id}
-          assert_not_nil(assigns(:user_feedback))
-          assert_equal([], assigns(:user_feedback).errors.full_messages)
+          post_auth user_feedbacks_path, @critic, params: {:user_feedback => {:category => "positive", :user_name => @user.name, :body => "xxx"}}
         end
       end
     end
 
+    context "update action" do
+      should "update the feedback" do
+        as(@critic) do
+          @feedback = create(:user_feedback, user: @user, category: "negative")
+        end
+        put_auth user_feedback_path(@feedback), @critic, params: { id: @feedback.id, user_feedback: { category: "positive" }}
+
+        assert_redirected_to(@feedback)
+        assert("positive", @feedback.reload.category)
+      end
+    end
+
     context "destroy action" do
       setup do
-        @user_feedback = FactoryGirl.create(:user_feedback, user: @user)
+        as(@critic) do
+          @user_feedback = create(:user_feedback, user: @user)
+        end
       end
 
       should "delete a feedback" do
         assert_difference "UserFeedback.count", -1 do
-          post :destroy, {:id => @user_feedback.id}, {:user_id => @critic.id}
+          delete_auth user_feedback_path(@user_feedback), @critic
         end
       end
 
       context "by a moderator" do
         should "allow deleting feedbacks given to other users" do
           assert_difference "UserFeedback.count", -1 do
-            post :destroy, {:id => @user_feedback.id}, {:user_id => @mod.id}
+            delete_auth user_feedback_path(@user_feedback), @mod
           end
         end
 
         should "not allow deleting feedbacks given to themselves" do
-          @user_feedback = FactoryGirl.create(:user_feedback, user: @mod)
+          as(@critic) do
+            @user_feedback = create(:user_feedback, user: @mod)
+          end
+
           assert_difference "UserFeedback.count", 0 do
-            post :destroy, {:id => @user_feedback.id}, {:user_id => @mod.id}
+            delete_auth user_feedback_path(@user_feedback), @mod
           end
         end
       end