Raise error on unpermitted params.

Fail loudly if we forget to whitelist a param instead of silently
ignoring it.

misc models: convert to strong params.

artist commentaries: convert to strong params.

* Disallow changing or setting post_id to a nonexistent post.

artists: convert to strong params.

* Disallow setting `is_banned` in create/update actions. Changing it
  this way instead of with the ban/unban actions would leave the artist in
  a partially banned state.

bans: convert to strong params.

* Disallow changing the user_id after the ban has been created.

comments: convert to strong params.

favorite groups: convert to strong params.

news updates: convert to strong params.

post appeals: convert to strong params.

post flags: convert to strong params.

* Disallow users from setting the `is_deleted` / `is_resolved` flags.

ip bans: convert to strong params.

user feedbacks: convert to strong params.

* Disallow users from setting `disable_dmail_notification` when creating feedbacks.
* Disallow changing the user_id after the feedback has been created.

notes: convert to strong params.

wiki pages: convert to strong params.

* Also fix non-Builders being able to delete wiki pages.

saved searches: convert to strong params.

pools: convert to strong params.

* Disallow setting `post_count` or `is_deleted` in create/update actions.

janitor trials: convert to strong params.

post disapprovals: convert to strong params.

* Factor out quick-mod bar to shared partial.
* Fix quick-mod bar to use `Post#is_approvable?` to determine visibility
  of Approve button.

dmail filters: convert to strong params.

password resets: convert to strong params.

user name change requests: convert to strong params.

posts: convert to strong params.

users: convert to strong params.

* Disallow setting password_hash, last_logged_in_at, last_forum_read_at,
  has_mail, and dmail_filter_attributes[user_id].

* Remove initialize_default_image_size (dead code).

uploads: convert to strong params.

* Remove `initialize_status` because status already defaults to pending
  in the database.

tag aliases/implications: convert to strong params.

tags: convert to strong params.

forum posts: convert to strong params.

* Disallow changing the topic_id after creating the post.
* Disallow setting is_deleted (destroy/undelete actions should be used instead).
* Remove is_sticky / is_locked (nonexistent attributes).

forum topics: convert to strong params.

* merges https://github.com/evazion/danbooru/tree/wip-rails-5.1
* lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4)
* switch to factorybot and change all references

Co-authored-by: r888888888 <r888888888@gmail.com>
Co-authored-by: evazion <noizave@gmail.com>

add diffs

test/functional/user_name_change_requests_controller_test.rb

@@ -1,41 +1,45 @@
 require 'test_helper'
 
-class UserNameChangeRequestsControllerTest < ActionController::TestCase
+class UserNameChangeRequestsControllerTest < ActionDispatch::IntegrationTest
   context "The user name change requests controller" do
     setup do
-      @user = FactoryGirl.create(:gold_user)
-      @admin = FactoryGirl.create(:admin_user)
-      CurrentUser.user = @user
-      CurrentUser.ip_addr = "127.0.0.1"
-      @change_request = UserNameChangeRequest.create!(
-        :user_id => @user.id,
-        :original_name => @user.name,
-        :desired_name => "abc",
-        :change_reason => "hello"
-      )
+      @user = create(:gold_user)
+      @admin = create(:admin_user)
+      as(@user) do
+        @change_request = UserNameChangeRequest.create!(
+          :user_id => @user.id,
+          :original_name => @user.name,
+          :desired_name => "abc",
+          :change_reason => "hello"
+        )
+      end
     end
     
     context "new action" do
       should "render" do
-        get :new, {}, {:user_id => @user.id}
+        get_auth new_user_name_change_request_path, @user
+        assert_response :success
+      end
+    end
+
+    context "create action" do
+      should "work" do
+        post_auth user_name_change_requests_path, @user, params: { user_name_change_request: { desired_name: "zun" }}
         assert_response :success
       end
     end
     
     context "show action" do
       should "render" do
-        get :show, {:id => @change_request.id}, {:user_id => @user.id}
+        get_auth user_name_change_request_path(@change_request), @user
         assert_response :success
       end
 
       context "when the current user is not an admin and does not own the request" do
-        setup do
-          CurrentUser.user = FactoryGirl.create(:user)
-        end
-
         should "fail" do
-          get :show, {:id => @change_request.id}
-          assert_redirected_to(new_session_path(:url => user_name_change_request_path(@change_request)))
+          @another_user = create(:user)
+          get_auth user_name_change_request_path(@change_request), @another_user
+          assert_response :forbidden
         end
       end
     end
@@ -43,21 +47,21 @@ class UserNameChangeRequestsControllerTest < ActionController::TestCase
     context "for actions restricted to admins" do
       context "index action" do
         should "render" do
-          get :index, {}, {:user_id => @admin.id}
+          get_auth user_name_change_requests_path, @admin
           assert_response :success
         end
       end
       
       context "approve action" do
         should "succeed" do
-          post :approve, {:id => @change_request.id}, {:user_id => @admin.id}
+          post_auth approve_user_name_change_request_path(@change_request), @admin
           assert_redirected_to(user_name_change_request_path(@change_request))
         end
       end
       
       context "reject action" do
         should "succeed" do
-          post :reject, {:id => @change_request.id}, {:user_id => @admin.id}
+          post_auth reject_user_name_change_request_path(@change_request), @admin
           assert_redirected_to(user_name_change_request_path(@change_request))
         end
       end