Raise error on unpermitted params.

Fail loudly if we forget to whitelist a param instead of silently
ignoring it.

misc models: convert to strong params.

artist commentaries: convert to strong params.

* Disallow changing or setting post_id to a nonexistent post.

artists: convert to strong params.

* Disallow setting `is_banned` in create/update actions. Changing it
  this way instead of with the ban/unban actions would leave the artist in
  a partially banned state.

bans: convert to strong params.

* Disallow changing the user_id after the ban has been created.

comments: convert to strong params.

favorite groups: convert to strong params.

news updates: convert to strong params.

post appeals: convert to strong params.

post flags: convert to strong params.

* Disallow users from setting the `is_deleted` / `is_resolved` flags.

ip bans: convert to strong params.

user feedbacks: convert to strong params.

* Disallow users from setting `disable_dmail_notification` when creating feedbacks.
* Disallow changing the user_id after the feedback has been created.

notes: convert to strong params.

wiki pages: convert to strong params.

* Also fix non-Builders being able to delete wiki pages.

saved searches: convert to strong params.

pools: convert to strong params.

* Disallow setting `post_count` or `is_deleted` in create/update actions.

janitor trials: convert to strong params.

post disapprovals: convert to strong params.

* Factor out quick-mod bar to shared partial.
* Fix quick-mod bar to use `Post#is_approvable?` to determine visibility
  of Approve button.

dmail filters: convert to strong params.

password resets: convert to strong params.

user name change requests: convert to strong params.

posts: convert to strong params.

users: convert to strong params.

* Disallow setting password_hash, last_logged_in_at, last_forum_read_at,
  has_mail, and dmail_filter_attributes[user_id].

* Remove initialize_default_image_size (dead code).

uploads: convert to strong params.

* Remove `initialize_status` because status already defaults to pending
  in the database.

tag aliases/implications: convert to strong params.

tags: convert to strong params.

forum posts: convert to strong params.

* Disallow changing the topic_id after creating the post.
* Disallow setting is_deleted (destroy/undelete actions should be used instead).
* Remove is_sticky / is_locked (nonexistent attributes).

forum topics: convert to strong params.

* merges https://github.com/evazion/danbooru/tree/wip-rails-5.1
* lock pg gem to 0.21 (1.0.0 is incompatible with rails 5.1.4)
* switch to factorybot and change all references

Co-authored-by: r888888888 <r888888888@gmail.com>
Co-authored-by: evazion <noizave@gmail.com>

add diffs

test/unit/downloads/file_test.rb

@@ -4,6 +4,7 @@ module Downloads
   class FileTest < ActiveSupport::TestCase
     context "A twitter video download" do
       setup do
+        skip "Twitter is not configured" unless Danbooru.config.twitter_api_key
         @source = "https://twitter.com/CincinnatiZoo/status/859073537713328129"
         @download = Downloads::File.new(@source)
       end

test/unit/downloads/pawoo_test.rb

@@ -4,6 +4,7 @@ module Downloads
   class PawooTest < ActiveSupport::TestCase
     context "downloading a 'https://pawoo.net/web/statuses/:id' url" do
       should "download the original file" do
+        skip "Pawoo keys not set" unless Danbooru.config.pawoo_client_id
         @source = "https://pawoo.net/web/statuses/1202176"
         @rewrite = "https://img.pawoo.net/media_attachments/files/000/128/953/original/4c0a06087b03343f.png"
         assert_rewritten(@rewrite, @source)
@@ -13,6 +14,7 @@ module Downloads
 
     context "downloading a 'https://pawoo.net/:user/:id' url" do
       should "download the original file" do
+        skip "Pawoo keys not set" unless Danbooru.config.pawoo_client_id
         @source = "https://pawoo.net/@9ed00e924818/1202176"
         @rewrite = "https://img.pawoo.net/media_attachments/files/000/128/953/original/4c0a06087b03343f.png"
         assert_rewritten(@rewrite, @source)
@@ -22,6 +24,7 @@ module Downloads
 
     context "downloading a 'https://img.pawoo.net/media_attachments/:id/small/:file' url" do
       should "download the original file" do
+        skip "Pawoo keys not set" unless Danbooru.config.pawoo_client_id
         @source = "https://img.pawoo.net/media_attachments/files/000/128/953/small/4c0a06087b03343f.png"
         @rewrite = "https://img.pawoo.net/media_attachments/files/000/128/953/original/4c0a06087b03343f.png"
         assert_rewritten(@rewrite, @source)

test/unit/downloads/tumblr_test.rb

@@ -4,6 +4,7 @@ module Downloads
   class TumblrTest < ActiveSupport::TestCase
     context "a download for a tumblr 500 sample" do
       should "instead download the raw version" do
+        skip "Tumblr keys are not set" unless Danbooru.config.tumblr_consumer_key
         @source = "https://24.media.tumblr.com/fc328250915434e66e8e6a92773f79d0/tumblr_mf4nshfibc1s0oswoo1_500.jpg"
         @rewrite = "http://data.tumblr.com/fc328250915434e66e8e6a92773f79d0/tumblr_mf4nshfibc1s0oswoo1_raw.jpg"
         assert_rewritten(@rewrite, @source)
@@ -13,6 +14,7 @@ module Downloads
 
     context "a download for a *.media.tumblr.com/tumblr_$id_$size image without a larger size" do
       should "download the same version" do
+        skip "Tumblr keys are not set" unless Danbooru.config.tumblr_consumer_key
         @source = "https://25.media.tumblr.com/tumblr_lxbzel2H5y1r9yjhso1_500.jpg"
         @rewrite = "http://data.tumblr.com/tumblr_lxbzel2H5y1r9yjhso1_500.jpg"
         assert_rewritten(@rewrite, @source)
@@ -22,6 +24,7 @@ module Downloads
 
     context "a download for a *.media.tumblr.com/tumblr_$id_$size image with a larger size" do
       should "download the best available version" do
+        skip "Tumblr keys are not set" unless Danbooru.config.tumblr_consumer_key
         @source = "https://25.media.tumblr.com/tumblr_m2dxb8aOJi1rop2v0o1_500.png"
         @rewrite = "http://data.tumblr.com/tumblr_m2dxb8aOJi1rop2v0o1_1280.png"
         assert_rewritten(@rewrite, @source)
@@ -31,6 +34,7 @@ module Downloads
 
     context "a download for a *.media.tumblr.com/$hash/tumblr_$id_rN_$size image" do
       should "download the best available version" do
+        skip "Tumblr keys are not set" unless Danbooru.config.tumblr_consumer_key
         @source = "https://33.media.tumblr.com/4b7fecf9a5a8284fbaefb051a2369b55/tumblr_npozqfwc9h1rt6u7do1_r1_500.gif"
         @rewrite = "http://data.tumblr.com/4b7fecf9a5a8284fbaefb051a2369b55/tumblr_npozqfwc9h1rt6u7do1_r1_raw.gif"
         assert_rewritten(@rewrite, @source)
@@ -40,6 +44,7 @@ module Downloads
 
     context "a download for a *.media.tumblr.com/$hash/tumblr_inline_$id_$size image" do
       should "download the best available version" do
+        skip "Tumblr keys are not set" unless Danbooru.config.tumblr_consumer_key
         @source = "https://68.media.tumblr.com/ee02048f5578595badc95905e17154b4/tumblr_inline_ofbr4452601sk4jd9_250.gif"
         @rewrite = "http://data.tumblr.com/ee02048f5578595badc95905e17154b4/tumblr_inline_ofbr4452601sk4jd9_500.gif"
         assert_rewritten(@rewrite, @source)
@@ -49,6 +54,7 @@ module Downloads
 
     context "a download for a data.tumblr.com/$id_$size image with a larger size" do
       should "download the best available version" do
+        skip "Tumblr keys are not set" unless Danbooru.config.tumblr_consumer_key
         @source = "http://data.tumblr.com/0DNBGJovY5j3smfeQs8nB53z_400.jpg"
         @rewrite = "http://data.tumblr.com/0DNBGJovY5j3smfeQs8nB53z_500.jpg"
         assert_rewritten(@rewrite, @source)
@@ -58,6 +64,7 @@ module Downloads
 
     context "a download for a data.tumblr.com/tumblr_$id_$size.jpg image" do
       should "download the best available version" do
+        skip "Tumblr keys are not set" unless Danbooru.config.tumblr_consumer_key
         @source = "http://data.tumblr.com/tumblr_m24kbxqKAX1rszquso1_250.jpg"
         @rewrite = "http://data.tumblr.com/tumblr_m24kbxqKAX1rszquso1_1280.jpg"
         assert_rewritten(@rewrite, @source)
@@ -67,6 +74,7 @@ module Downloads
 
     context "a download for a gs1.wac.edgecastcdn.net image" do
       should "rewrite to the full tumblr version" do
+        skip "Tumblr keys are not set" unless Danbooru.config.tumblr_consumer_key
         @source = "https://gs1.wac.edgecastcdn.net/8019B6/data.tumblr.com/tumblr_m2dxb8aOJi1rop2v0o1_500.png"
         @rewrite = "http://data.tumblr.com/tumblr_m2dxb8aOJi1rop2v0o1_1280.png"
 
@@ -77,6 +85,7 @@ module Downloads
 
     context "a download for a *.tumblr.com/post/* html page" do
       should "download the best available version" do
+        skip "Tumblr keys are not set" unless Danbooru.config.tumblr_consumer_key
         @source = "https://noizave.tumblr.com/post/162206271767"
         @rewrite = "http://data.tumblr.com/3bbfcbf075ddf969c996641b264086fd/tumblr_os2buiIOt51wsfqepo1_raw.png"
 

test/unit/downloads/twitter_test.rb

@@ -4,6 +4,7 @@ module Downloads
   class TwitterTest < ActiveSupport::TestCase
     context "downloading a 'https://twitter.com/:user/status/:id' url containing a video" do
       should "download the largest video" do
+        skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
         @source = "https://twitter.com/CincinnatiZoo/status/859073537713328129"
         @rewrite = "https://video.twimg.com/ext_tw_video/859073467769126913/pu/vid/1280x720/cPGgVROXHy3yrK6u.mp4"
         assert_rewritten(@rewrite, @source)
@@ -13,6 +14,7 @@ module Downloads
 
     context "downloading a 'https://twitter.com/:user/status/:id/photo/:n' card url" do
       should "download the orig file" do
+        skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
         @source = "https://twitter.com/masayasuf/status/870734961778630656/photo/1"
         @rewrite = "https://pbs.twimg.com/media/DBV40M2UIAAHYlt.jpg:orig"
         assert_rewritten(@rewrite, @source)
@@ -22,6 +24,7 @@ module Downloads
 
     context "downloading a 'https://mobile.twitter.com/:user/status/:id/photo/:n' mobile url" do
       should "download the orig file" do
+        skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
         @source = "https://mobile.twitter.com/Strangestone/status/556440271961858051"
         @rewrite = "https://pbs.twimg.com/media/B7jfc1JCcAEyeJh.png:orig"
         assert_rewritten(@rewrite, @source)
@@ -31,6 +34,7 @@ module Downloads
 
     context "downloading a 'https://pbs.twimg.com/media/*:large' url" do
       should "download the orig file" do
+        skip "Twitter key is not set" unless Danbooru.config.twitter_api_key
         @source = "https://pbs.twimg.com/media/B4HSEP5CUAA4xyu.png:large"
         @rewrite = "https://pbs.twimg.com/media/B4HSEP5CUAA4xyu.png:orig"
         assert_rewritten(@rewrite, @source)